fix: duckdb test corrections

Author: cofin

sqlspec/adapters/duckdb/config.py

@@ -5,7 +5,6 @@
 from typing import TYPE_CHECKING, Any, cast
 
 from duckdb import DuckDBPyConnection
-from duckdb import connect as duckdb_connect
 
 from sqlspec.base import GenericDatabaseConfig, NoPoolConfig
 from sqlspec.exceptions import ImproperConfigurationError
@@ -176,9 +175,10 @@ def create_connection(self) -> DuckDBPyConnection:
         Raises:
             ImproperConfigurationError: If the connection could not be established or extensions could not be configured.
         """
+        import duckdb
 
         try:
-            connection = duckdb_connect(**self.connection_config_dict)
+            connection = duckdb.connect(**self.connection_config_dict)  # pyright: ignore[reportUnknownMemberType]
             self._configure_extensions(connection)
             return connection
         except Exception as e:

sqlspec/base.py

@@ -1,8 +1,8 @@
 from abc import ABC, abstractmethod
 from collections.abc import AsyncGenerator, Awaitable, Generator
 from contextlib import AbstractAsyncContextManager, AbstractContextManager
-from dataclasses import dataclass, field
-from typing import Any, Generic, TypeVar, Union
+from dataclasses import dataclass
+from typing import Any, ClassVar, Generic, TypeVar, Union
 
 __all__ = (
     "DatabaseConfigProtocol",
@@ -18,8 +18,8 @@
 class DatabaseConfigProtocol(Generic[ConnectionT, PoolT], ABC):
     """Protocol defining the interface for database configurations."""
 
-    __is_async__: bool = field(default=False, init=False)
-    __supports_connection_pooling__: bool = field(default=False, init=False)
+    __is_async__: ClassVar[bool] = False
+    __supports_connection_pooling__: ClassVar[bool] = False
 
     @abstractmethod
     def create_connection(self) -> Union[ConnectionT, Awaitable[ConnectionT]]:

tests/unit/test_adapters/test_duckdb/test_config.py

@@ -6,6 +6,7 @@
 from unittest.mock import MagicMock, patch
 
 import pytest
+from _pytest.fixtures import FixtureRequest
 
 from sqlspec.adapters.duckdb.config import DuckDBConfig, ExtensionConfig
 from sqlspec.exceptions import ImproperConfigurationError
@@ -217,6 +218,7 @@ def test_invalid_extensions_type_error(self) -> None:
     )
     def test_configure_extensions(
         self,
+        request: FixtureRequest,
         mock_duckdb_connection: MagicMock,
         extension_config: ExtensionConfig,
         expected_calls: list[tuple[str, dict[str, Any]]],
@@ -228,7 +230,7 @@ def test_configure_extensions(
         actual_calls = []
         for method_name, kwargs in expected_calls:
             method = getattr(connection, method_name)
-            assert method.called
+            assert method.called, f"Method {method_name} was not called"
             if method_name == "execute":
                 actual_calls.append((method_name, {"query": method.call_args.args[0]}))
             else:

tests/unit/test_utils/test_module_loader.py

@@ -37,7 +37,7 @@ def test_module_path(tmp_path: Path, monkeypatch: MonkeyPatch) -> None:
 
 def test_import_non_existing_attribute_raises() -> None:
     with pytest.raises(ImportError):
-        import_string("sqlspec.base.GenericDatabaseConfig")
+        import_string("sqlspec.base.GenericDatabaseConfig.extra.module")
 
 
 def test_import_string_cached(tmp_path: Path, monkeypatch: MonkeyPatch) -> None: