feat(lifespan): remove lifespan from main configurations (#12)

* feat(lifespan): remove lifespan from main configurations

* chore: updated test

Author: cofin

sqlspec/adapters/aiosqlite/config.py

@@ -78,22 +78,6 @@ async def create_connection(self) -> Connection:
             msg = f"Could not configure the Aiosqlite connection. Error: {e!s}"
             raise ImproperConfigurationError(msg) from e
 
-    @asynccontextmanager
-    async def lifespan(self, *args: Any, **kwargs: Any) -> AsyncGenerator[None, None]:
-        """Manage the lifecycle of a database connection.
-
-        Yields:
-            None
-
-        Raises:
-            ImproperConfigurationError: If the connection could not be established.
-        """
-        connection = await self.create_connection()
-        try:
-            yield
-        finally:
-            await connection.close()
-
     @asynccontextmanager
     async def provide_connection(self, *args: Any, **kwargs: Any) -> AsyncGenerator[Connection, None]:
         """Create and provide a database connection.

sqlspec/adapters/asyncmy/config.py

@@ -161,23 +161,6 @@ async def provide_pool(self, *args: Any, **kwargs: Any) -> Pool:
         """
         return await self.create_pool()
 
-    @asynccontextmanager
-    async def lifespan(self, *args: Any, **kwargs: Any) -> AsyncGenerator[None, None]:
-        """Manage the lifecycle of a database connection pool.
-
-        Yields:
-            None
-
-        Raises:
-            ImproperConfigurationError: If the pool could not be established.
-        """
-        pool = await self.create_pool()
-        try:
-            yield
-        finally:
-            pool.close()
-            await pool.wait_closed()
-
     @asynccontextmanager
     async def provide_connection(self, *args: Any, **kwargs: Any) -> AsyncGenerator[Connection, None]:
         """Create and provide a database connection.

sqlspec/adapters/asyncpg/config.py

@@ -123,15 +123,6 @@ async def create_pool(self) -> Pool:
             )
         return self.pool_instance
 
-    @asynccontextmanager
-    async def lifespan(self, *args: Any, **kwargs: Any) -> AsyncGenerator[None, None]:
-        db_pool = await self.create_pool()
-        try:
-            yield
-        finally:
-            db_pool.terminate()
-            await db_pool.close()
-
     def provide_pool(self, *args: Any, **kwargs: Any) -> Awaitable[Pool]:
         """Create a pool instance.
 

sqlspec/adapters/duckdb/config.py

@@ -184,22 +184,6 @@ def create_connection(self) -> DuckDBPyConnection:
             msg = f"Could not configure the DuckDB connection. Error: {e!s}"
             raise ImproperConfigurationError(msg) from e
 
-    @contextmanager
-    def lifespan(self, *args: Any, **kwargs: Any) -> Generator[None, None, None]:
-        """Manage the lifecycle of a database connection.
-
-        Yields:
-            None
-
-        Raises:
-            ImproperConfigurationError: If the connection could not be established.
-        """
-        connection = self.create_connection()
-        try:
-            yield
-        finally:
-            connection.close()
-
     @contextmanager
     def provide_connection(self, *args: Any, **kwargs: Any) -> Generator[DuckDBPyConnection, None, None]:
         """Create and provide a database connection.

sqlspec/adapters/oracledb/config/_asyncio.py

@@ -75,14 +75,6 @@ async def create_pool(self) -> AsyncConnectionPool:
             raise ImproperConfigurationError(msg)
         return self.pool_instance
 
-    @asynccontextmanager
-    async def lifespan(self, *args: Any, **kwargs: Any) -> AsyncGenerator[None, None]:
-        db_pool = await self.create_pool()
-        try:
-            yield
-        finally:
-            await db_pool.close(force=True)
-
     def provide_pool(self, *args: Any, **kwargs: Any) -> Awaitable[AsyncConnectionPool]:
         """Create a pool instance.
 

sqlspec/adapters/oracledb/config/_sync.py

@@ -75,13 +75,6 @@ def create_pool(self) -> ConnectionPool:
             raise ImproperConfigurationError(msg)
         return self.pool_instance
 
-    def lifespan(self, *args: Any, **kwargs: Any) -> Generator[None, None, None]:
-        db_pool = self.create_pool()
-        try:
-            yield
-        finally:
-            db_pool.close()
-
     def provide_pool(self, *args: Any, **kwargs: Any) -> ConnectionPool:
         """Create a pool instance.
 

sqlspec/adapters/psycopg/config/_async.py

@@ -63,15 +63,6 @@ async def create_pool(self) -> AsyncConnectionPool:
             raise ImproperConfigurationError(msg)
         return self.pool_instance
 
-    @asynccontextmanager
-    async def lifespan(self, *args: Any, **kwargs: Any) -> AsyncGenerator[None, None]:
-        """Manage the lifecycle of the connection pool."""
-        pool = await self.create_pool()
-        try:
-            yield
-        finally:
-            await pool.close()
-
     def provide_pool(self, *args: Any, **kwargs: Any) -> Awaitable[AsyncConnectionPool]:
         """Create and return a connection pool."""
         return self.create_pool()

sqlspec/adapters/psycopg/config/_sync.py

@@ -63,15 +63,6 @@ def create_pool(self) -> ConnectionPool:
             raise ImproperConfigurationError(msg)
         return self.pool_instance
 
-    @contextmanager
-    def lifespan(self, *args: Any, **kwargs: Any) -> Generator[None, None, None]:
-        """Manage the lifecycle of the connection pool."""
-        pool = self.create_pool()
-        try:
-            yield
-        finally:
-            pool.close()
-
     def provide_pool(self, *args: Any, **kwargs: Any) -> ConnectionPool:
         """Create and return a connection pool."""
         return self.create_pool()

sqlspec/adapters/sqlite/config.py

@@ -75,22 +75,6 @@ def create_connection(self) -> Connection:
             msg = f"Could not configure the SQLite connection. Error: {e!s}"
             raise ImproperConfigurationError(msg) from e
 
-    @contextmanager
-    def lifespan(self, *args: Any, **kwargs: Any) -> Generator[None, None, None]:
-        """Manage the lifecycle of a database connection.
-
-        Yields:
-            None
-
-        Raises:
-            ImproperConfigurationError: If the connection could not be established.
-        """
-        connection = self.create_connection()
-        try:
-            yield
-        finally:
-            connection.close()
-
     @contextmanager
     def provide_connection(self, *args: Any, **kwargs: Any) -> Generator[Connection, None, None]:
         """Create and provide a database connection.

tests/unit/test_adapters/test_duckdb/test_config.py

@@ -250,19 +250,3 @@ def test_connection_creation_error(self) -> None:
             config = DuckDBConfig()
             with pytest.raises(ImproperConfigurationError, match="Could not configure"):
                 config.create_connection()
-
-    def test_connection_lifecycle(self, mock_duckdb_connection: MagicMock) -> None:
-        """Test connection lifecycle management."""
-        config = DuckDBConfig()
-
-        # Test lifespan
-        with config.lifespan():
-            assert mock_duckdb_connection.close.call_count == 0
-        assert mock_duckdb_connection.close.call_count == 1
-
-        # Test provide_connection
-        mock_duckdb_connection.reset_mock()
-        with config.provide_connection() as conn:
-            assert conn is mock_duckdb_connection
-            assert mock_duckdb_connection.close.call_count == 0
-        assert mock_duckdb_connection.close.call_count == 1