fix: enhance logging filter to cover additional sqlglot loggers and silence MySQL notes during fixture cleanup

Author: cofin

sqlspec/utils/logging.py

@@ -166,6 +166,7 @@ def suppress_erroneous_sqlglot_log_messages() -> None:
     about falling back to parsing as a Command. This is expected behavior
     in SQLSpec and the warning is confusing to users.
     """
-    sqlglot_logger = logging.getLogger("sqlglot")
-    if not any(isinstance(f, SqlglotCommandFallbackFilter) for f in sqlglot_logger.filters):
-        sqlglot_logger.addFilter(SqlglotCommandFallbackFilter())
+    for logger_name in ("sqlglot", "sqlglot.scope", "sqlglot.generator"):
+        sqlglot_logger = logging.getLogger(logger_name)
+        if not any(isinstance(f, SqlglotCommandFallbackFilter) for f in sqlglot_logger.filters):
+            sqlglot_logger.addFilter(SqlglotCommandFallbackFilter())

tests/integration/test_adapters/test_asyncmy/conftest.py

@@ -37,6 +37,8 @@ async def asyncmy_driver(asyncmy_config: AsyncmyConfig) -> AsyncGenerator[Asyncm
 async def asyncmy_clean_driver(asyncmy_config: AsyncmyConfig) -> AsyncGenerator[AsyncmyDriver, None]:
     """Create AsyncMy driver with clean database state."""
     async with asyncmy_config.provide_session() as driver:
+        # Silence MySQL "unknown table" notes during fixture cleanup to avoid noisy logs
+        await driver.execute("SET sql_notes = 0")
         # Clean up any test tables that might exist
         cleanup_tables = [
             "test_table",
@@ -66,11 +68,17 @@ async def asyncmy_clean_driver(asyncmy_config: AsyncmyConfig) -> AsyncGenerator[
         for proc in cleanup_procedures:
             await driver.execute_script(f"DROP PROCEDURE IF EXISTS {proc}")
 
+        await driver.execute("SET sql_notes = 1")
+
         yield driver
 
+        await driver.execute("SET sql_notes = 0")
+
         # Cleanup after test
         for table in cleanup_tables:
             await driver.execute_script(f"DROP TABLE IF EXISTS {table}")
 
         for proc in cleanup_procedures:
             await driver.execute_script(f"DROP PROCEDURE IF EXISTS {proc}")
+
+        await driver.execute("SET sql_notes = 1")

tests/integration/test_adapters/test_asyncmy/test_asyncmy_features.py

@@ -257,9 +257,10 @@ async def test_asyncmy_sql_object_advanced_features(asyncmy_pooled_session: Asyn
         """
         INSERT INTO advanced_test (name, metadata, score)
         VALUES (?, ?, ?)
+        AS new_vals
         ON DUPLICATE KEY UPDATE
-        score = VALUES(score) + ?,
-        metadata = JSON_MERGE_PATCH(metadata, VALUES(metadata))
+        score = new_vals.score + ?,
+        metadata = JSON_MERGE_PATCH(metadata, new_vals.metadata)
         """,
         "complex_test",
         '{"type": "advanced", "priority": 1}',