fix: psycopg pool deprecation (#38)

Corrects a psycopg deprecation error

Author: cofin

docs/examples/litestar_asyncpg.py

@@ -15,7 +15,7 @@
 """
 # /// script
 # dependencies = [
-#   "sqlspec[asyncpg,performance] @ git+https://github.com/litestar-org/sqlspec.git@main",
+#   "sqlspec[asyncpg,performance]",
 #   "litestar[standard]",
 # ]
 # ///

docs/examples/litestar_duckllm.py

@@ -8,7 +8,7 @@
 
 # /// script
 # dependencies = [
-#   "sqlspec[duckdb,performance] @ git+https://github.com/litestar-org/sqlspec.git@main",
+#   "sqlspec[duckdb,performance]",
 #   "litestar[standard]",
 # ]
 # ///

docs/examples/litestar_multi_db.py

@@ -8,7 +8,7 @@
 """
 # /// script
 # dependencies = [
-#   "sqlspec[aiosqlite,duckdb] @ git+https://github.com/litestar-org/sqlspec.git@main",
+#   "sqlspec[aiosqlite,duckdb]",
 #   "litestar[standard]",
 # ]
 # ///

docs/examples/litestar_psycopg.py

@@ -8,7 +8,7 @@
 """
 # /// script
 # dependencies = [
-#   "sqlspec[psycopg] @ git+https://github.com/litestar-org/sqlspec.git@main",
+#   "sqlspec[psycopg]",
 #   "litestar[standard]",
 # ]
 # ///

docs/examples/standalone_demo.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python3
 # /// script
 # dependencies = [
-#   "sqlspec[duckdb,performance] @ git+https://github.com/litestar-org/sqlspec.git@main",
+#   "sqlspec[duckdb,performance]",
 #   "rich>=13.0.0",
 #   "rich-click>=1.7.0",
 #   "faker>=24.0.0",

docs/examples/standalone_duckdb.py

@@ -5,7 +5,7 @@
 
 # /// script
 # dependencies = [
-#   "sqlspec[duckdb,performance] @ git+https://github.com/litestar-org/sqlspec.git@main",
+#   "sqlspec[duckdb,performance]",
 # ]
 # ///
 

sqlspec/adapters/psycopg/config.py

@@ -606,74 +606,58 @@ def pool_config_dict(self) -> dict[str, Any]:
 
     async def _create_pool(self) -> "AsyncConnectionPool":
         """Create the actual async connection pool."""
-        logger.info("Creating async Psycopg connection pool", extra={"adapter": "psycopg"})
 
-        try:
-            # Get all config (creates a new dict)
-            all_config = self.pool_config_dict.copy()
+        # Get all config (creates a new dict)
+        all_config = self.pool_config_dict.copy()
+
+        # Separate pool-specific parameters that AsyncConnectionPool accepts directly
+        pool_params = {
+            "min_size": all_config.pop("min_size", 4),
+            "max_size": all_config.pop("max_size", None),
+            "name": all_config.pop("name", None),
+            "timeout": all_config.pop("timeout", 30.0),
+            "max_waiting": all_config.pop("max_waiting", 0),
+            "max_lifetime": all_config.pop("max_lifetime", 3600.0),
+            "max_idle": all_config.pop("max_idle", 600.0),
+            "reconnect_timeout": all_config.pop("reconnect_timeout", 300.0),
+            "num_workers": all_config.pop("num_workers", 3),
+        }
 
-            # Separate pool-specific parameters that AsyncConnectionPool accepts directly
-            pool_params = {
-                "min_size": all_config.pop("min_size", 4),
-                "max_size": all_config.pop("max_size", None),
-                "name": all_config.pop("name", None),
-                "timeout": all_config.pop("timeout", 30.0),
-                "max_waiting": all_config.pop("max_waiting", 0),
-                "max_lifetime": all_config.pop("max_lifetime", 3600.0),
-                "max_idle": all_config.pop("max_idle", 600.0),
-                "reconnect_timeout": all_config.pop("reconnect_timeout", 300.0),
-                "num_workers": all_config.pop("num_workers", 3),
-            }
+        # Create a configure callback to set row_factory
+        async def configure_connection(conn: "PsycopgAsyncConnection") -> None:
+            # Set DictRow as the row factory
+            conn.row_factory = dict_row
 
-            # Create a configure callback to set row_factory
-            async def configure_connection(conn: "PsycopgAsyncConnection") -> None:
-                # Set DictRow as the row factory
-                conn.row_factory = dict_row
+        pool_params["configure"] = all_config.pop("configure", configure_connection)
 
-            pool_params["configure"] = all_config.pop("configure", configure_connection)
+        # Remove None values from pool_params
+        pool_params = {k: v for k, v in pool_params.items() if v is not None}
 
-            # Remove None values from pool_params
-            pool_params = {k: v for k, v in pool_params.items() if v is not None}
+        # Handle conninfo vs individual connection parameters
+        conninfo = all_config.pop("conninfo", None)
+        if conninfo:
+            # If conninfo is provided, use it directly
+            # Don't pass kwargs when using conninfo string
+            pool = AsyncConnectionPool(conninfo, open=False, **pool_params)
+        else:
+            # Otherwise, pass connection parameters via kwargs
+            # Remove any non-connection parameters
+            # row_factory is already popped out earlier
+            all_config.pop("row_factory", None)
+            # Remove pool-specific settings that may have been left
+            all_config.pop("kwargs", None)
+            pool = AsyncConnectionPool("", kwargs=all_config, open=False, **pool_params)
 
-            # Handle conninfo vs individual connection parameters
-            conninfo = all_config.pop("conninfo", None)
-            if conninfo:
-                # If conninfo is provided, use it directly
-                # Don't pass kwargs when using conninfo string
-                pool = AsyncConnectionPool(conninfo, **pool_params)
-            else:
-                # Otherwise, pass connection parameters via kwargs
-                # Remove any non-connection parameters
-                # row_factory is already popped out earlier
-                all_config.pop("row_factory", None)
-                # Remove pool-specific settings that may have been left
-                all_config.pop("kwargs", None)
-                pool = AsyncConnectionPool("", kwargs=all_config, **pool_params)
+        await pool.open()
 
-            await pool.open()
-            logger.info("Async Psycopg connection pool created successfully", extra={"adapter": "psycopg"})
-        except Exception as e:
-            logger.exception(
-                "Failed to create async Psycopg connection pool", extra={"adapter": "psycopg", "error": str(e)}
-            )
-            raise
         return pool
 
     async def _close_pool(self) -> None:
         """Close the actual async connection pool."""
         if not self.pool_instance:
             return
 
-        logger.info("Closing async Psycopg connection pool", extra={"adapter": "psycopg"})
-
-        try:
-            await self.pool_instance.close()
-            logger.info("Async Psycopg connection pool closed successfully", extra={"adapter": "psycopg"})
-        except Exception as e:
-            logger.exception(
-                "Failed to close async Psycopg connection pool", extra={"adapter": "psycopg", "error": str(e)}
-            )
-            raise
+        await self.pool_instance.close()
 
     async def create_connection(self) -> "PsycopgAsyncConnection":  # pyright: ignore
         """Create a single async connection (not from pool).