Skip to content

Commit 3c3cd78

Browse files
committed
Remove Checkstyle suppressions file and fix Checkstyle issues introduced in 24e8399 and 8c1041d
The Checkstyle suppressions file is now replaced by // CHECKSTYLE:OFF and // CHECKSTYLE:ON comments.
1 parent 2e1c5c1 commit 3c3cd78

File tree

4 files changed

+5
-23
lines changed

4 files changed

+5
-23
lines changed

checkstyle/checkstyle.xml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,6 @@
2020
<property name="fileNamePattern" value="module\-info\.java$"/>
2121
</module>
2222

23-
<!-- https://checkstyle.org/config_filters.html#SuppressionFilter -->
24-
<module name="SuppressionFilter">
25-
<property name="file" value="${config_loc}/suppressions.xml" />
26-
<property name="optional" value="true"/>
27-
</module>
28-
2923
<!-- Checks that a package-info.java file exists for each package. -->
3024
<!-- See https://checkstyle.org/config_javadoc.html#JavadocPackage -->
3125
<!--<module name="JavadocPackage"/>-->
@@ -68,6 +62,8 @@
6862

6963
<module name="SuppressWarningsFilter" />
7064

65+
<module name="SuppressWithPlainTextCommentFilter"/>
66+
7167
<module name="TreeWalker">
7268
<!-- Checks for Javadoc comments. -->
7369
<!-- See https://checkstyle.org/config_javadoc.html -->

checkstyle/suppressions.xml

Lines changed: 0 additions & 15 deletions
This file was deleted.

extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampExtractorHelper.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ public static String getStreamUrlFromIds(final long bandId,
5454

5555
/**
5656
* Fetch artist details from mobile endpoint.
57-
* <a href=https://notabug.org/fynngodau/bandcampDirect/wiki/rewindBandcamp+%E2%80%93+Fetching+artist+details>
57+
* <a href="https://notabug.org/fynngodau/bandcampDirect/wiki/
58+
* rewindBandcamp+%E2%80%93+Fetching+artist+details">
5859
* More technical info.</a>
5960
*/
6061
public static JsonObject getArtistDetails(final String id) throws ParsingException {

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/ItagItem.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
public class ItagItem {
1919
/**
2020
* List can be found here
21-
* https://github.com/ytdl-org/youtube-dl/blob/9fc5eafb8e384453a49f7cfe73147be491f0b19d/youtube_dl/extractor/youtube.py#L1071
21+
* https://github.com/ytdl-org/youtube-dl/blob/9fc5eaf/youtube_dl/extractor/youtube.py#L1071
2222
*/
2323
private static final ItagItem[] ITAG_LIST = {
2424
/////////////////////////////////////////////////////

0 commit comments

Comments
 (0)