YoutubeThrottlingDecrypter: Check if returned string is a valid JavaScript function

Author: litetex

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeThrottlingDecrypter.java

@@ -5,12 +5,13 @@
 import org.schabi.newpipe.extractor.utils.Parser;
 import org.schabi.newpipe.extractor.utils.StringUtils;
 
-import javax.annotation.Nonnull;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
+import javax.annotation.Nonnull;
+
 /**
  * YouTube's streaming URLs of HTML5 clients are protected with a cipher, which modifies their
  * {@code n} query parameter.
@@ -154,16 +155,25 @@ private static String parseDecodeFunction(final String playerJsCode, final Strin
     private static String parseWithParenthesisMatching(final String playerJsCode,
                                                        final String functionName) {
         final String functionBase = functionName + "=function";
-        return functionBase + StringUtils.matchToClosingParenthesis(playerJsCode, functionBase)
-                + ";";
+        return validateFunction(functionBase
+                + StringUtils.matchToClosingParenthesis(playerJsCode, functionBase)
+                + ";");
     }
 
     @Nonnull
     private static String parseWithRegex(final String playerJsCode, final String functionName)
             throws Parser.RegexException {
         final Pattern functionPattern = Pattern.compile(functionName + "=function(.*?};)\n",
                 Pattern.DOTALL);
-        return "function " + functionName + Parser.matchGroup1(functionPattern, playerJsCode);
+        return validateFunction("function "
+                + functionName
+                + Parser.matchGroup1(functionPattern, playerJsCode));
+    }
+
+    @Nonnull
+    private static String validateFunction(@Nonnull final String function) {
+        JavaScript.compileOrThrow(function);
+        return function;
     }
 
     @Deprecated

extractor/src/main/java/org/schabi/newpipe/extractor/utils/JavaScript.java

@@ -9,6 +9,18 @@ public final class JavaScript {
     private JavaScript() {
     }
 
+    public static void compileOrThrow(final String function) {
+        try {
+            final Context context = Context.enter();
+            context.setOptimizationLevel(-1);
+
+            // If it doesn't compile it throws an exception here
+            context.compileString(function, null, 1, null);
+        } finally {
+            Context.exit();
+        }
+    }
+
     public static String run(final String function,
                              final String functionName,
                              final String... parameters) {