chore: test on Jackson 2.14.0 to avoid encountering FasterXML/jackson-databind#3240 in tests

fix: date time deserialization leniency

Author: stainless-app[bot]

README.md

@@ -416,6 +416,8 @@ If the SDK threw an exception, but you're _certain_ the version is compatible, t
 > [!CAUTION]
 > We make no guarantee that the SDK works correctly when the Jackson version check is disabled.
 
+Also note that there are bugs in older Jackson versions that can affect the SDK. We don't work around all Jackson bugs ([example](https://github.com/FasterXML/jackson-databind/issues/3240)) and expect users to upgrade Jackson for those instead.
+
 ## Network options
 
 ### Retries

lithic-java-core/build.gradle.kts

@@ -5,14 +5,16 @@ plugins {
 
 configurations.all {
     resolutionStrategy {
-        // Compile and test against a lower Jackson version to ensure we're compatible with it.
-        // We publish with a higher version (see below) to ensure users depend on a secure version by default.
-        force("com.fasterxml.jackson.core:jackson-core:2.13.4")
-        force("com.fasterxml.jackson.core:jackson-databind:2.13.4")
-        force("com.fasterxml.jackson.core:jackson-annotations:2.13.4")
-        force("com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.13.4")
-        force("com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.13.4")
-        force("com.fasterxml.jackson.module:jackson-module-kotlin:2.13.4")
+        // Compile and test against a lower Jackson version to ensure we're compatible with it. Note that
+        // we generally support 2.13.4, but test against 2.14.0 because 2.13.4 has some annoying (but
+        // niche) bugs (users should upgrade if they encounter them). We publish with a higher version
+        // (see below) to ensure users depend on a secure version by default.
+        force("com.fasterxml.jackson.core:jackson-core:2.14.0")
+        force("com.fasterxml.jackson.core:jackson-databind:2.14.0")
+        force("com.fasterxml.jackson.core:jackson-annotations:2.14.0")
+        force("com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.14.0")
+        force("com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.14.0")
+        force("com.fasterxml.jackson.module:jackson-module-kotlin:2.14.0")
     }
 }
 

lithic-java-core/src/main/kotlin/com/lithic/api/core/ObjectMappers.kt

@@ -37,7 +37,7 @@ fun jsonMapper(): JsonMapper =
         .addModule(
             SimpleModule()
                 .addSerializer(InputStreamSerializer)
-                .addDeserializer(LocalDateTime::class.java, LenientLocalDateTimeDeserializer())
+                .addDeserializer(OffsetDateTime::class.java, LenientOffsetDateTimeDeserializer())
                 .addDeserializer(OffsetDateTime::class.java, LenientOffsetDateTimeDeserializer())
         )
         .withCoercionConfig(LogicalType.Boolean) {
@@ -66,6 +66,12 @@ fun jsonMapper(): JsonMapper =
                 .setCoercion(CoercionInputShape.Array, CoercionAction.Fail)
                 .setCoercion(CoercionInputShape.Object, CoercionAction.Fail)
         }
+        .withCoercionConfig(LogicalType.DateTime) {
+            it.setCoercion(CoercionInputShape.Integer, CoercionAction.Fail)
+                .setCoercion(CoercionInputShape.Float, CoercionAction.Fail)
+                .setCoercion(CoercionInputShape.Array, CoercionAction.Fail)
+                .setCoercion(CoercionInputShape.Object, CoercionAction.Fail)
+        }
         .withCoercionConfig(LogicalType.Array) {
             it.setCoercion(CoercionInputShape.Boolean, CoercionAction.Fail)
                 .setCoercion(CoercionInputShape.Integer, CoercionAction.Fail)
@@ -126,10 +132,10 @@ private object InputStreamSerializer : BaseSerializer<InputStream>(InputStream::
 }
 
 /**
- * A deserializer that can deserialize [LocalDateTime] from datetimes, dates, and zoned datetimes.
+ * A deserializer that can deserialize [OffsetDateTime] from datetimes, dates, and zoned datetimes.
  */
-private class LenientLocalDateTimeDeserializer :
-    StdDeserializer<LocalDateTime>(LocalDateTime::class.java) {
+private class LenientOffsetDateTimeDeserializer :
+    StdDeserializer<OffsetDateTime>(OffsetDateTime::class.java) {
 
     companion object {
 
@@ -143,26 +149,28 @@ private class LenientLocalDateTimeDeserializer :
 
     override fun logicalType(): LogicalType = LogicalType.DateTime
 
-    override fun deserialize(p: JsonParser, context: DeserializationContext?): LocalDateTime {
+    override fun deserialize(p: JsonParser, context: DeserializationContext): OffsetDateTime {
         val exceptions = mutableListOf<Exception>()
 
         for (formatter in DATE_TIME_FORMATTERS) {
             try {
                 val temporal = formatter.parse(p.text)
 
                 return when {
-                    !temporal.isSupported(ChronoField.HOUR_OF_DAY) ->
-                        LocalDate.from(temporal).atStartOfDay()
-                    !temporal.isSupported(ChronoField.OFFSET_SECONDS) ->
-                        LocalDateTime.from(temporal)
-                    else -> ZonedDateTime.from(temporal).toLocalDateTime()
-                }
+                        !temporal.isSupported(ChronoField.HOUR_OF_DAY) ->
+                            LocalDate.from(temporal).atStartOfDay()
+                        !temporal.isSupported(ChronoField.OFFSET_SECONDS) ->
+                            LocalDateTime.from(temporal)
+                        else -> ZonedDateTime.from(temporal).toLocalDateTime()
+                    }
+                    .atZone(context.timeZone.toZoneId())
+                    .toOffsetDateTime()
             } catch (e: DateTimeException) {
                 exceptions.add(e)
             }
         }
 
-        throw JsonParseException(p, "Cannot parse `LocalDateTime` from value: ${p.text}").apply {
+        throw JsonParseException(p, "Cannot parse `OffsetDateTime` from value: ${p.text}").apply {
             exceptions.forEach { addSuppressed(it) }
         }
     }

lithic-java-core/src/main/kotlin/com/lithic/api/models/CardProvisionResponse.kt

@@ -364,7 +364,7 @@ private constructor(
                         .toList()
                 return when (bestMatches.size) {
                     // This can happen if what we're deserializing is completely incompatible with
-                    // all the possible variants (e.g. deserializing from array).
+                    // all the possible variants (e.g. deserializing from boolean).
                     0 -> ProvisioningPayload(_json = json)
                     1 -> bestMatches.single()
                     // If there's more than one match with the highest validity, then use the first

lithic-java-core/src/main/kotlin/com/lithic/api/models/ConditionalValue.kt

@@ -247,7 +247,7 @@ private constructor(
                     .toList()
             return when (bestMatches.size) {
                 // This can happen if what we're deserializing is completely incompatible with all
-                // the possible variants (e.g. deserializing from object).
+                // the possible variants (e.g. deserializing from boolean).
                 0 -> ConditionalValue(_json = json)
                 1 -> bestMatches.single()
                 // If there's more than one match with the highest validity, then use the first

lithic-java-core/src/test/kotlin/com/lithic/api/core/ObjectMappersTest.kt

@@ -3,7 +3,6 @@ package com.lithic.api.core
 import com.fasterxml.jackson.annotation.JsonProperty
 import com.fasterxml.jackson.databind.exc.MismatchedInputException
 import com.fasterxml.jackson.module.kotlin.readValue
-import java.time.LocalDateTime
 import java.time.OffsetDateTime
 import kotlin.reflect.KClass
 import org.assertj.core.api.Assertions.assertThat
@@ -59,14 +58,6 @@ internal class ObjectMappersTest {
                     LONG to DOUBLE,
                     LONG to INTEGER,
                     CLASS to MAP,
-                    // These aren't actually valid, but coercion configs don't work for String until
-                    // v2.14.0: https://github.com/FasterXML/jackson-databind/issues/3240
-                    // We currently test on v2.13.4.
-                    BOOLEAN to STRING,
-                    FLOAT to STRING,
-                    DOUBLE to STRING,
-                    INTEGER to STRING,
-                    LONG to STRING,
                 )
         }
     }
@@ -85,7 +76,7 @@ internal class ObjectMappersTest {
         }
     }
 
-    enum class LenientLocalDateTimeTestCase(val string: String) {
+    enum class LenientOffsetDateTimeTestCase(val string: String) {
         DATE("1998-04-21"),
         DATE_TIME("1998-04-21T04:00:00"),
         ZONED_DATE_TIME_1("1998-04-21T04:00:00+03:00"),
@@ -94,11 +85,11 @@ internal class ObjectMappersTest {
 
     @ParameterizedTest
     @EnumSource
-    fun readLocalDateTime_lenient(testCase: LenientLocalDateTimeTestCase) {
+    fun readOffsetDateTime_lenient(testCase: LenientOffsetDateTimeTestCase) {
         val jsonMapper = jsonMapper()
         val json = jsonMapper.writeValueAsString(testCase.string)
 
-        assertDoesNotThrow { jsonMapper().readValue<LocalDateTime>(json) }
+        assertDoesNotThrow { jsonMapper().readValue<OffsetDateTime>(json) }
     }
 
     enum class LenientOffsetDateTimeTestCase(val string: String) {

lithic-java-core/src/test/kotlin/com/lithic/api/models/ConditionalValueTest.kt

@@ -10,6 +10,8 @@ import java.time.OffsetDateTime
 import org.assertj.core.api.Assertions.assertThat
 import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.assertThrows
+import org.junit.jupiter.params.ParameterizedTest
+import org.junit.jupiter.params.provider.EnumSource
 
 internal class ConditionalValueTest {
 
@@ -118,10 +120,17 @@ internal class ConditionalValueTest {
         assertThat(roundtrippedConditionalValue).isEqualTo(conditionalValue)
     }
 
-    @Test
-    fun incompatibleJsonShapeDeserializesToUnknown() {
-        val value = JsonValue.from(mapOf("invalid" to "object"))
-        val conditionalValue = jsonMapper().convertValue(value, jacksonTypeRef<ConditionalValue>())
+    enum class IncompatibleJsonShapeTestCase(val value: JsonValue) {
+        BOOLEAN(JsonValue.from(false)),
+        FLOAT(JsonValue.from(3.14)),
+        OBJECT(JsonValue.from(mapOf("invalid" to "object"))),
+    }
+
+    @ParameterizedTest
+    @EnumSource
+    fun incompatibleJsonShapeDeserializesToUnknown(testCase: IncompatibleJsonShapeTestCase) {
+        val conditionalValue =
+            jsonMapper().convertValue(testCase.value, jacksonTypeRef<ConditionalValue>())
 
         val e = assertThrows<LithicInvalidDataException> { conditionalValue.validate() }
         assertThat(e).hasMessageStartingWith("Unknown ")

lithic-java-proguard-test/build.gradle.kts

@@ -19,7 +19,7 @@ dependencies {
     testImplementation(kotlin("test"))
     testImplementation("org.junit.jupiter:junit-jupiter-api:5.9.3")
     testImplementation("org.assertj:assertj-core:3.25.3")
-    testImplementation("com.fasterxml.jackson.module:jackson-module-kotlin:2.13.4")
+    testImplementation("com.fasterxml.jackson.module:jackson-module-kotlin:2.14.0")
 }
 
 tasks.shadowJar {