Skip to content

Commit b2cea59

Browse files
committed
fix: unwrap webhooks into payload, not event
1 parent 566f588 commit b2cea59

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ while (page != null) {
254254

255255
We provide helper methods for verifying that a webhook request came from Lithic, and not a malicious third party.
256256

257-
You can use `lithic.webhooks().verifySignature(body, headers, secret?)` or `lithic.webhooks().unwrap(body, headers, secret?) -> Event`.
257+
You can use `lithic.webhooks().verifySignature(body, headers, secret?)` or `lithic.webhooks().unwrap(body, headers, secret?)`.
258258

259259
---
260260

lithic-java-core/src/main/kotlin/com/lithic/api/services/async/WebhookServiceAsync.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
package com.lithic.api.services.async
44

55
import com.google.common.collect.ListMultimap
6-
import com.lithic.api.models.Event
6+
import com.lithic.api.core.JsonValue
77

88
interface WebhookServiceAsync {
99

10-
fun unwrap(payload: String, headers: ListMultimap<String, String>, secret: String?): Event
10+
fun unwrap(payload: String, headers: ListMultimap<String, String>, secret: String?): JsonValue
1111

1212
fun verifySignature(payload: String, headers: ListMultimap<String, String>, secret: String?)
1313
}

lithic-java-core/src/main/kotlin/com/lithic/api/services/async/WebhookServiceAsyncImpl.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ package com.lithic.api.services.async
33
import com.fasterxml.jackson.core.JsonProcessingException
44
import com.google.common.collect.ListMultimap
55
import com.lithic.api.core.ClientOptions
6+
import com.lithic.api.core.JsonValue
67
import com.lithic.api.core.http.HttpResponse.Handler
78
import com.lithic.api.errors.LithicError
89
import com.lithic.api.errors.LithicException
9-
import com.lithic.api.models.Event
1010
import com.lithic.api.services.errorHandler
1111
import java.security.MessageDigest
1212
import java.time.Duration
@@ -26,10 +26,10 @@ constructor(
2626
payload: String,
2727
headers: ListMultimap<String, String>,
2828
secret: String?
29-
): Event {
29+
): JsonValue {
3030
verifySignature(payload, headers, secret)
3131
return try {
32-
clientOptions.jsonMapper.readValue(payload, Event::class.java)
32+
clientOptions.jsonMapper.readValue(payload, JsonValue::class.java)
3333
} catch (e: JsonProcessingException) {
3434
throw LithicException("Invalid event payload", e)
3535
}

lithic-java-core/src/main/kotlin/com/lithic/api/services/blocking/WebhookService.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
package com.lithic.api.services.blocking
44

55
import com.google.common.collect.ListMultimap
6-
import com.lithic.api.models.Event
6+
import com.lithic.api.core.JsonValue
77

88
interface WebhookService {
99

10-
fun unwrap(payload: String, headers: ListMultimap<String, String>, secret: String?): Event
10+
fun unwrap(payload: String, headers: ListMultimap<String, String>, secret: String?): JsonValue
1111

1212
fun verifySignature(payload: String, headers: ListMultimap<String, String>, secret: String?)
1313
}

lithic-java-core/src/main/kotlin/com/lithic/api/services/blocking/WebhookServiceImpl.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ package com.lithic.api.services.blocking
33
import com.fasterxml.jackson.core.JsonProcessingException
44
import com.google.common.collect.ListMultimap
55
import com.lithic.api.core.ClientOptions
6+
import com.lithic.api.core.JsonValue
67
import com.lithic.api.core.http.HttpResponse.Handler
78
import com.lithic.api.errors.LithicError
89
import com.lithic.api.errors.LithicException
9-
import com.lithic.api.models.Event
1010
import com.lithic.api.services.errorHandler
1111
import java.security.MessageDigest
1212
import java.time.Duration
@@ -26,10 +26,10 @@ constructor(
2626
payload: String,
2727
headers: ListMultimap<String, String>,
2828
secret: String?
29-
): Event {
29+
): JsonValue {
3030
verifySignature(payload, headers, secret)
3131
return try {
32-
clientOptions.jsonMapper.readValue(payload, Event::class.java)
32+
clientOptions.jsonMapper.readValue(payload, JsonValue::class.java)
3333
} catch (e: JsonProcessingException) {
3434
throw LithicException("Invalid event payload", e)
3535
}

0 commit comments

Comments
 (0)