[cuegui] Fix dependency wizard progress dialog hanging at 100% for grouped jobs (AcademySoftwareFoundation#1995)

**Link the Issue(s) this Pull Request is related to.**
- AcademySoftwareFoundation#1994

**Summarize your change.**

[cuegui] Fix dependency wizard progress dialog hanging at 100% for
grouped jobs

The progress dialog would get stuck at 100% completion when creating
dependencies on grouped jobs (show-shot, show-shot-username). Users had
to restart CueGUI or double-cancel to dismiss the dialog.

Changes:
- Enhanced completion detection with fallback progress bar check
- Added safety timer to prevent indefinite hanging
- Improved thread safety with proper Qt main thread cleanup
- Added robust error handling for edge cases

The dialog now automatically closes upon completion regardless of job
grouping configuration.

Fixes issue where dependency creation completed successfully but the
progress dialog remained visible and unresponsive.

Author: ramonfigueiredo

cuegui/cuegui/ProgressDialog.py

@@ -65,6 +65,11 @@ def __init__(self, title, function, work, concurrent, cancelTitle,
         self.__count = 0
         self.__isCompleted = False
 
+        # Add a safety timer to prevent hanging dialogs
+        self.__safetyTimer = QtCore.QTimer(self)
+        self.__safetyTimer.timeout.connect(self.__checkCompletion)
+        self.__safetyTimer.start(1000)  # Check every second
+
         self.__bar = QtWidgets.QProgressBar(self)
         self.__bar.setRange(0, len(self.__work))
         self.__bar.setValue(0)
@@ -96,6 +101,7 @@ def closeEvent(self, event):
         """Handle dialog close attempts"""
         if self.__isCompleted:
             # Work is done, allow closing
+            self.__safetyTimer.stop()
             event.accept()
             super(ProgressDialog, self).closeEvent(event)
         else:
@@ -134,6 +140,7 @@ def cancel(self):
                 self.__workLock.unlock()
             # Mark as completed and close the dialog when user confirms cancellation
             self.__isCompleted = True
+            self.__safetyTimer.stop()
             self.close()
 
     def __doWork(self):
@@ -154,6 +161,8 @@ def __doWork(self):
             except Exception as e:
                 logger.warning("Work unit returned exception:")
                 list(map(logger.warning, cuegui.Utils.exceptionOutput(e)))
+                # Even if work fails, we need to ensure proper count management
+                # The __doneWork callback will still be called by the threadpool
 
     def __doneWork(self, work, result):
         """Called when a work unit is done, updates progress, exits if done
@@ -173,14 +182,32 @@ def __doneWork(self, work, result):
             if self.__work:
                 self._submitWork()
             else:
-                if self.__count == 0:
+                # Check if all work is completed - both no work left AND count is 0
+                # or if progress bar shows 100% completion
+                if self.__count <= 0 or self.__bar.value() >= self.__bar.maximum():
                     if self.__cancelConfirmation:
                         self.__cancelConfirmation.close()
                     self.__isCompleted = True
-                    self.close()
+                    # Use QTimer to ensure proper cleanup in the main thread
+                    QtCore.QTimer.singleShot(0, self.close)
         finally:
             self.__workLock.unlock()
 
+    def __checkCompletion(self):
+        """Safety check to ensure dialog completion detection works properly"""
+        if self.__isCompleted:
+            self.__safetyTimer.stop()
+            return
+
+        # Check if we should be completed based on progress
+        if (not self.__work and self.__count <= 0) or self.__bar.value() >= self.__bar.maximum():
+            logger.debug("Safety timer detected completion - closing dialog")
+            if self.__cancelConfirmation:
+                self.__cancelConfirmation.close()
+            self.__isCompleted = True
+            self.__safetyTimer.stop()
+            self.close()
+
     def _submitWork(self):
         """Submits a new unit of work to threadpool"""
         self.__count += 1