Commit cfc32ef
[cueman] Add unit tests and validation for frame operations (AcademySoftwareFoundation#1999)
**Link the Issue(s) this Pull Request is related to.**
- AcademySoftwareFoundation#1929
- AcademySoftwareFoundation#1800
**Summarize your change.**
Summary:
Add comprehensive unit tests for frame-specific operations and implement
input validation for stagger, reorder, and frame range operations.
Updated documentation to reflect new validation requirements.
Changes:
1) Unit tests (`cueman/tests/test_frame_operations.py`)
Created comprehensive test suite covering:
- Frame eat/kill/retry operations with layer and range filters
- Frame state filtering (running, waiting, dead, succeeded)
- Frame range parsing and validation
- Mark done functionality
- Stagger operations with increment validation (positive integers only)
- Reorder operations with position validation (FIRST, LAST, REVERSE)
- Confirmation prompts for destructive operations
- Error handling for invalid inputs
2) Input validation (`cueman/cueman/main.py`)
Added validation to ensure:
- Stagger increments must be positive integers (rejects 0, negative,
non-numeric)
- Reorder positions must be FIRST, LAST, or REVERSE
- Frame ranges must be valid numeric formats with start < = end
3) Documentation updates
Updated documentation across multiple files:
- `docs/_docs/reference/tools/cueman.md`: Added validation notes and
troubleshooting examples for invalid inputs
- `docs/_docs/tutorials/cueman-tutorial.md`: Added validation notes in
Frame Manipulation section and error examples
- `cueman/cueman_tutorial.md`: Added validation notes for stagger and
reorder
- `cueman/README.md`: Updated inline comments to reflect requirements
4) Test fixes
- Fixed typo in test method name: from `test_done_fundtionality` to
`test_done_functionality`
- Corrected layer parameter type from string to list in 7 tests to match
argparse `nargs="+"` behavior
- Updated assertions to expect list values for consistency with actual
command-line argument parsing
Co-authored-by: Kathy Lee <lee.j.kathy@gmail.com>
Co-authored-by: Ramon Figueiredo <rfigueiredo@imageworks.com>1 parent ca9b210 commit cfc32ef
File tree
6 files changed
+478
-2
lines changed- cueman
- cueman
- tests
- docs/_docs
- reference/tools
- tutorials
6 files changed
+478
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
217 | 217 | | |
218 | 218 | | |
219 | 219 | | |
220 | | - | |
| 220 | + | |
221 | 221 | | |
222 | 222 | | |
223 | | - | |
| 223 | + | |
224 | 224 | | |
225 | 225 | | |
226 | 226 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
567 | 567 | | |
568 | 568 | | |
569 | 569 | | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
570 | 573 | | |
571 | 574 | | |
572 | 575 | | |
| |||
591 | 594 | | |
592 | 595 | | |
593 | 596 | | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
594 | 600 | | |
595 | 601 | | |
596 | 602 | | |
| |||
725 | 731 | | |
726 | 732 | | |
727 | 733 | | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
728 | 742 | | |
729 | 743 | | |
730 | 744 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
376 | 376 | | |
377 | 377 | | |
378 | 378 | | |
| 379 | + | |
| 380 | + | |
379 | 381 | | |
380 | 382 | | |
381 | 383 | | |
| |||
393 | 395 | | |
394 | 396 | | |
395 | 397 | | |
| 398 | + | |
| 399 | + | |
396 | 400 | | |
397 | 401 | | |
398 | 402 | | |
| |||
0 commit comments