feat(aws-az-chaos): add an error message when using elbv2 in parallel mode as it can't work, boto3 enforces at least one subnet per load balancer. Also fix a missing ref in aws_az class.

Signed-off-by: Guillaume R 63466144+Guigui0812@users.noreply.github.com

Author: Guigui0812

chaosLib/litmus/aws_az_chaos/lib/aws_az_chaos.py

@@ -20,7 +20,11 @@ def PrepareAWSAZExperiment(experimentsDetails , resultDetails, eventsDetails, ch
 		if err != None:
 			return err
 	elif experimentsDetails.Sequence.lower() == "parallel":
-		err = injectChaosInParallelMode(experimentsDetails, chaosDetails, eventsDetails, resultDetails, clients, statusAws)
+		if experimentsDetails.LoadBalancerVersion == "elb":
+			err = injectChaosInParallelMode(experimentsDetails, chaosDetails, eventsDetails, resultDetails, clients, statusAws)
+		elif experimentsDetails.LoadBalancerVersion == "elbv2":
+			logging.info("[Sequence]: aws az chaos is not available in parallel mode with elbv2 as it requires at least one subnet per LoadBalancer")
+			return ValueError("aws az chaos is not available in parallel mode with elbv2 as it requires at least one subnet per LoadBalancer")
 		if err != None:
 			return err
 	else:
@@ -58,6 +62,10 @@ def injectChaosInSerialMode(experimentsDetails , chaosDetails , eventsDetails ,
 			if err != None:
 				return err
 
+			if targetSubnet is None:
+				logging.error("[Error]: No subnet found for the zone %s", azone)
+				return ValueError("No subnet found for the zone %s" % azone)
+   
 			if experimentsDetails.LoadBalancerVersion == "elb":
 				subnetList = list(targetSubnet.split(" "))
 				logging.info("[Info]: Detaching the following subnet, %s", subnetList)

pkg/aws_az/environment/environment.py

@@ -9,15 +9,15 @@ def GetENV(experimentDetails):
 	experimentDetails.ChaosNamespace = os.getenv("CHAOS_NAMESPACE", "")
 	experimentDetails.EngineName = os.getenv("CHAOSENGINE", "")
 	experimentDetails.ChaosDuration = maths.atoi(os.getenv("TOTAL_CHAOS_DURATION", "60"))
-	experimentDetails.ChaosInterval = os.getenv("CHAOS_INTERVAL", "30")
+	experimentDetails.ChaosInterval = os.getenv("CHAOS_INTERVAL", "60")
 	experimentDetails.RampTime = maths.atoi(os.getenv("RAMP_TIME", ""))
 	experimentDetails.ChaosLib = os.getenv("LIB", "litmus")
 	experimentDetails.ChaosUID = os.getenv("CHAOS_UID", "")
 	experimentDetails.InstanceID = os.getenv("INSTANCE_ID", "")
 	experimentDetails.ChaosPodName = os.getenv("POD_NAME", "")
 	experimentDetails.Delay = maths.atoi(os.getenv("STATUS_CHECK_DELAY", "2"))
 	experimentDetails.Timeout = maths.atoi(os.getenv("STATUS_CHECK_TIMEOUT", "180"))
-	experimentDetails.Sequence = os.getenv("SEQUENCE", "parallel")
+	experimentDetails.Sequence = os.getenv("SEQUENCE", "serial")
 	experimentDetails.AWSRegion = os.getenv("AWS_REGION", "")
 	experimentDetails.LoadBalancerName = os.getenv("LOAD_BALANCER_NAME", "")
 	experimentDetails.LoadBalancerZones = os.getenv("LOAD_BALANCER_ZONES", "")

pkg/aws_status/status.py

@@ -11,7 +11,7 @@ def __init__(self, client=None):
     # CheckAWSStatus checks target load balancer availability
     def CheckAWSStatus(self, experimentsDetails):
 
-        self.clients = client.AWSClient().clientElb
+        self.clients = client.AWSClient(experimentsDetails).clientElb
 
         if experimentsDetails.LoadBalancerName == "" or experimentsDetails.LoadBalancerZones == "" :
             return ValueError("Provided LoadBalancer Name or LoadBalancerZoner are empty")
@@ -108,11 +108,16 @@ def detachSubnetv2(self, experimentsDetails, subnet):
             for az in response['LoadBalancers'][0]['AvailabilityZones']:
                 if az['SubnetId'] not in subnet:
                     subnetsToKeep.append(az['SubnetId'])
-
-            response = client.set_subnets(
-                LoadBalancerArn=response['LoadBalancers'][0]['LoadBalancerArn'],
-                Subnets=subnetsToKeep
-            )
+            if experimentsDetails.Sequence is "parallel":
+                response = client.set_subnets(
+                    LoadBalancerArn=response['LoadBalancers'][0]['LoadBalancerArn'],
+                    Subnets=[""]
+                )
+            else:
+                response = client.set_subnets(
+                    LoadBalancerArn=response['LoadBalancers'][0]['LoadBalancerArn'],
+                    Subnets=subnetsToKeep
+                )
 
         except (self.clients.exceptions.AccessPointNotFoundException, self.clients.exceptions.InvalidConfigurationRequestException) as exp:
             return ValueError(exp)