refactor: Replace hardcoded strings with translations#5417
Open
r6mez wants to merge 7 commits intolitmuschaos:masterfrom
Open
refactor: Replace hardcoded strings with translations#5417r6mez wants to merge 7 commits intolitmuschaos:masterfrom
r6mez wants to merge 7 commits intolitmuschaos:masterfrom
Conversation
r6mez
changed the title
SahilKr24
approved these changes
Mar 17, 2026
Member
|
@PriteshKiri can we get rid of the unused variable? |
SarthakJain26
approved these changes
Mar 17, 2026
Contributor
|
@r6mez could you please rebase your PR? The build failure will be fixed once you push that. |
Signed-off-by: Ramez Medhat <iramezdev@gmail.com>
Signed-off-by: Ramez Medhat <iramezdev@gmail.com>
Signed-off-by: Ramez Medhat <iramezdev@gmail.com>
Signed-off-by: Ramez Medhat <iramezdev@gmail.com>
r6mez
force-pushed
the
replace-strings-with-translations
branch
from
f61e968 to
6e33b86
Compare
Signed-off-by: Ramez Medhat <iramezdev@gmail.com>
r6mez
force-pushed
the
replace-strings-with-translations
branch
from
c102352 to
d02908b
Compare
Author
Sure, I removed it. |
Author
Done. |
This fixes a double-advance bug in the AddProbeModalWizard by changing the Formik onSubmit handler to noop, so the nextStep() isn't called twice. It also fixes the validation regex for time units to allow empty optional fields, and updates a test matcher to account for lowercase translation text. Signed-off-by: Ramez Medhat <iramezdev@gmail.com>
r6mez
force-pushed
the
replace-strings-with-translations
branch
from
89ab77a to
f179dee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pull request focuses on improving internationalization across several UI components by replacing hardcoded user-facing strings with calls to the
getStringfunction, ensuring all text is sourced from the translation files.Additionally, it updates the corresponding test files
Closes #4147
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Dependency
Special notes for your reviewer: