Skip to content

Commit 1c5c7c4

Browse files
the-mikedavislittleblack111
authored andcommitted
Avoid cloning language server names in Document::save
`language_servers` is a `HashMap<String, Arc<Client>>` so the clients are cheap to clone but not the language server names. The names are unused in the save future so we can avoid the unnecessary clones by looking only at the `HashMap::values`.
1 parent 9e9545a commit 1c5c7c4

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

helix-view/src/document.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -981,7 +981,7 @@ impl Document {
981981
};
982982

983983
let identifier = self.path().map(|_| self.identifier());
984-
let language_servers = self.language_servers.clone();
984+
let language_servers: Vec<_> = self.language_servers.values().cloned().collect();
985985

986986
// mark changes up to now as saved
987987
let current_rev = self.get_current_revision();
@@ -1125,7 +1125,7 @@ impl Document {
11251125
text: text.clone(),
11261126
};
11271127

1128-
for (_, language_server) in language_servers {
1128+
for language_server in language_servers {
11291129
if !language_server.is_initialized() {
11301130
continue;
11311131
}

0 commit comments

Comments
 (0)