Add path prefix dimming for file providers (#1130)

* Refactor: Add centralized theme and window management utilities

- Create theme_utils.vim with centralized color extraction and highlight management
- Create ui/window_manager.vim for buffer/window lifecycle management
- Update themes.vim to use centralized utilities instead of inline code
- Update floating_win.vim to use centralized winhl strings and color constants

This is Phase 1 of the fuzzy finder UI refactoring, establishing a foundation
for more extensible and maintainable UI components.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Add modular UI components: indicator, preview regions, layout builder

- Create indicator_components.vim with extensible component system
  - Support for match count, keybind hints, provider mode
  - Component registration with priority ordering
- Create preview_regions.vim for modular preview management
  - Header, content, and scrollbar region support
  - Rich header formatting with file info
  - Scrollbar position calculation
- Create layout_builder.vim for flexible window arrangement
  - Dimension calculation with percentage/keyword support
  - Layout presets (center, top, bottom)
  - Dynamic height support
  - Sub-window config builders

This is Phase 2 of the fuzzy finder UI refactoring.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Add UI orchestrator for component coordination

- Create orchestrator.vim to coordinate all UI components
- Event hooks system (before_open, after_open, on_resize, etc.)
- Backend detection (floating/popup/sidebar)
- High-level operations for open/close lifecycle
- Preview management integration
- Window focus coordination

This completes Phase 3 of the fuzzy finder UI refactoring foundation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Add visual polish: softer colors, improved selection, better borders

Visual improvements for a more modern and pleasant fuzzy finder experience:

- Softer match highlight colors using Tokyo Night-inspired palette
  - Blues (#7dcfff, #7aa2f7), cyans (#94e2d5), soft greens (#9ece6a)
  - Lavenders and pinks for variety (#cba6f7, #f5c2e7)
- Dimmed path prefix highlight groups (ClapPathPrefix, ClapFileName)
  - Directory paths dimmed, filenames bright and bold
- Improved current selection styling
  - Visible background highlight for current line
  - Nicer arrow indicator (▶) with customizable g:clap_current_selection_arrow
  - Better sign styling with filled circle (●) for multi-select
- Enhanced border styling
  - ClapBorder and ClapBorderText highlight groups
  - Subtle contrast for borders in dark/light modes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Revert "Add visual polish: softer colors, improved selection, better borders"

This reverts commit 6e7fce9.

* Add dimmed path prefix highlighting for file providers

- Directory prefixes are dimmed (ClapPathPrefix) while filenames stay bright (ClapFileName)
- Root-level files get consistent filename highlighting
- Works with icons, grep format (file:line:col), and both path separators
- Uses matchaddpos for reliable highlighting over signs
- Configurable via g:clap_enable_path_dimming (default: enabled)
- Highlight groups defined in s:init_theme() to work with all theme palettes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Remove unused UI component files

These modular UI components (orchestrator, layout_builder, indicator_components,
preview_regions, window_manager) were built as infrastructure but not yet
integrated into the main vim-clap code. Removing to keep the branch focused
on actively used changes.

* Merge theme_utils.vim into themes.vim

Consolidate theme utility functions (color extraction, highlight creation,
winhl strings) directly into themes.vim instead of having a separate file.
This simplifies the codebase while keeping the same functionality.

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: liuchengxu

autoload/clap/floating_win.vim

@@ -40,27 +40,30 @@ let s:symbol_left = g:__clap_search_box_border_symbol.left
 let s:symbol_right = g:__clap_search_box_border_symbol.right
 let s:symbol_width = strdisplaywidth(s:symbol_right)
 
-let s:shadow_winhl = 'Normal:ClapShadow,NormalNC:ClapShadow,EndOfBuffer:ClapShadow'
-let s:display_winhl = 'Normal:ClapDisplay,EndOfBuffer:ClapDisplayInvisibleEndOfBuffer,SignColumn:ClapDisplay,ColorColumn:ClapDisplay'
-let s:preview_winhl = 'Normal:ClapPreview,EndOfBuffer:ClapPreviewInvisibleEndOfBuffer,SignColumn:ClapPreview,ColorColumn:ClapPreview'
-let s:preview_scrollbar_winhl = 'Normal:ClapPreviewScrollbar,EndOfBuffer:ClapPreviewInvisibleEndOfBuffer,SignColumn:ClapPreviewScrollbar,ColorColumn:ClapPreviewScrollbar'
-
-if &background ==# 'dark'
-  if empty(get(g:clap_preview.scrollbar, 'fill_char', ''))
-    hi ClapDefaultPreviewScrollbar ctermbg=237 guibg=#3E4452 ctermfg=173 guifg=#e18254 cterm=bold,reverse gui=bold,reverse
-  else
-    let s:preview_scrollbar_fill_char = g:clap_preview.scrollbar.fill_char
-    hi ClapDefaultPreviewScrollbar ctermbg=237 guibg=#3E4452 ctermfg=173 guifg=#e18254 cterm=bold gui=bold
-  endif
-else
-  if empty(get(g:clap_preview.scrollbar, 'fill_char', ''))
-    hi ClapDefaultPreviewScrollbar ctermbg=7 guibg=#ecf5ff ctermfg=173 guifg=#e18254 cterm=bold,reverse gui=bold,reverse
-  else
-    let s:preview_scrollbar_fill_char = g:clap_preview.scrollbar.fill_char
-    hi ClapDefaultPreviewScrollbar ctermbg=7 guibg=#ecf5ff ctermfg=173 guifg=#e18254 cterm=bold gui=bold
-  endif
+" Use centralized winhl strings from themes
+let s:shadow_winhl = g:clap#themes#winhl.shadow
+let s:display_winhl = g:clap#themes#winhl.display
+let s:preview_winhl = g:clap#themes#winhl.preview
+let s:preview_scrollbar_winhl = clap#themes#winhl('ClapPreviewScrollbar', 'ClapPreviewInvisibleEndOfBuffer')
+
+" Setup preview scrollbar highlight using centralized colors
+let s:defaults = g:clap#themes#defaults
+let s:preview_bg = clap#themes#display_bg()
+let s:scrollbar_attrs = empty(get(g:clap_preview.scrollbar, 'fill_char', '')) ? 'bold,reverse' : 'bold'
+
+if !empty(get(g:clap_preview.scrollbar, 'fill_char', ''))
+  let s:preview_scrollbar_fill_char = g:clap_preview.scrollbar.fill_char
 endif
 
+call clap#themes#highlight('ClapDefaultPreviewScrollbar', {
+      \ 'guibg': s:preview_bg.gui,
+      \ 'ctermbg': s:preview_bg.cterm,
+      \ 'guifg': s:defaults.scrollbar_fg.gui,
+      \ 'ctermfg': s:defaults.scrollbar_fg.cterm,
+      \ 'gui': s:scrollbar_attrs,
+      \ 'cterm': s:scrollbar_attrs,
+      \ })
+
 hi default link ClapPreviewScrollbar ClapDefaultPreviewScrollbar
 
 " shadow

autoload/clap/highlighter/path.vim

@@ -0,0 +1,260 @@
+" Author: liuchengxu <xuliuchengxlc@gmail.com>
+" Description: Path highlighting - dims directory prefix, brightens filename.
+
+let s:save_cpo = &cpoptions
+set cpoptions&vim
+
+" Providers that display file paths and should have dimmed prefixes
+let s:path_providers = ['files', 'git_files', 'recent_files', 'history', 'filer', 'grep', 'live_grep', 'proj_tags', 'tags', 'jumps']
+
+" Check if the current provider should have path highlighting
+function! clap#highlighter#path#should_highlight() abort
+  if !get(g:, 'clap_enable_path_dimming', 1)
+    return v:false
+  endif
+  return index(s:path_providers, g:clap.provider.id) >= 0
+endfunction
+
+" Find path boundaries in a line
+" Returns: [prefix_start, prefix_end, filename_start, filename_end] or [] if not a path
+" All indices are byte-based, 0-indexed
+function! s:find_path_boundaries(line) abort
+  if empty(a:line)
+    return []
+  endif
+
+  " Determine the end of file path (before : for grep format, or end of line)
+  let l:path_end = len(a:line) - 1
+
+  " Check for grep format: file:line:col:content
+  " Find first colon that's followed by a digit (line number)
+  let l:colon_pos = 0
+  while l:colon_pos < len(a:line)
+    let l:colon_pos = stridx(a:line, ':', l:colon_pos)
+    if l:colon_pos == -1
+      break
+    endif
+    " Check if next char is a digit (line number)
+    if l:colon_pos + 1 < len(a:line) && a:line[l:colon_pos + 1] =~# '\d'
+      let l:path_end = l:colon_pos - 1
+      break
+    endif
+    let l:colon_pos += 1
+  endwhile
+
+  " Determine where the actual path starts (skip icon if present)
+  let l:path_start = 0
+  if g:__clap_icon_added_by_maple
+    " Icon is typically a multi-byte character + space
+    " Scan for first alnum or path character after initial icon bytes
+    let l:byte_idx = 0
+    for l:char in split(a:line, '\zs')
+      if l:byte_idx > 0 && (l:char =~# '[a-zA-Z0-9_./\\]')
+        let l:path_start = l:byte_idx
+        break
+      endif
+      let l:byte_idx += len(l:char)
+    endfor
+  endif
+
+  " Find the last path separator before path_end
+  let l:last_sep = -1
+  let l:byte_idx = 0
+  for l:char in split(a:line[:l:path_end], '\zs')
+    if l:char ==# '/' || l:char ==# '\'
+      let l:last_sep = l:byte_idx
+    endif
+    let l:byte_idx += len(l:char)
+  endfor
+
+  " Return: [prefix_start, prefix_end, filename_start, filename_end]
+  " For root-level files (no separator), prefix is -1,-1 and filename covers the whole name
+  if l:last_sep == -1
+    return [-1, -1, l:path_start, l:path_end]
+  endif
+
+  return [l:path_start, l:last_sep, l:last_sep + 1, l:path_end]
+endfunction
+
+" Use matchaddpos for higher priority highlighting (works in display window)
+" This is the same approach used by fuzzy match highlighting
+
+" Store match IDs in window-local variable for cleanup
+function! clap#highlighter#path#clear_matches() abort
+  if exists('w:clap_path_match_ids')
+    for l:id in w:clap_path_match_ids
+      try
+        call matchdelete(l:id)
+      catch
+        " Ignore if already deleted
+      endtry
+    endfor
+  endif
+  let w:clap_path_match_ids = []
+endfunction
+
+function! s:clear_path_highlights(bufnr) abort
+  if exists('*win_execute') && exists('g:clap.display.winid')
+    call win_execute(g:clap.display.winid, 'call clap#highlighter#path#clear_matches()')
+  endif
+endfunction
+
+" lnum is 0-based, col_start is 0-based byte index
+function! clap#highlighter#path#add_match(lnum, col_start, length, hl_group) abort
+  " matchaddpos uses 1-based line and column numbers
+  try
+    let l:id = matchaddpos(a:hl_group, [[a:lnum + 1, a:col_start + 1, a:length]], 5)
+    if !exists('w:clap_path_match_ids')
+      let w:clap_path_match_ids = []
+    endif
+    call add(w:clap_path_match_ids, l:id)
+  catch
+    " Ignore errors
+  endtry
+endfunction
+
+if has('nvim')
+  function! s:add_path_highlight(bufnr, lnum, col_start, col_end, hl_group) abort
+    let l:length = a:col_end - a:col_start + 1
+    if exists('*win_execute') && exists('g:clap.display.winid')
+      call win_execute(g:clap.display.winid,
+            \ 'call clap#highlighter#path#add_match(' . a:lnum . ',' . a:col_start . ',' . l:length . ',"' . a:hl_group . '")')
+    endif
+  endfunction
+else
+  function! s:add_path_highlight(bufnr, lnum, col_start, col_end, hl_group) abort
+    try
+      call prop_add(a:lnum + 1, a:col_start + 1, {
+            \ 'length': a:col_end - a:col_start + 1,
+            \ 'type': a:hl_group,
+            \ 'bufnr': a:bufnr
+            \ })
+    catch
+      " Ignore errors
+    endtry
+  endfunction
+endif
+
+" Debug function to check if path highlighting is working
+function! clap#highlighter#path#debug() abort
+  echo 'Provider: ' . g:clap.provider.id
+  echo 'Should highlight: ' . clap#highlighter#path#should_highlight()
+  echo 'Icon added: ' . g:__clap_icon_added_by_maple
+  echo 'Display bufnr: ' . g:clap.display.bufnr
+  echo 'Display winid: ' . g:clap.display.winid
+  echo ''
+
+  " Test with actual display lines
+  let l:lines = getbufline(g:clap.display.bufnr, 1, 5)
+  echo 'Display lines (' . len(l:lines) . '):'
+  for l:i in range(len(l:lines))
+    echo 'Line ' . l:i . ': "' . l:lines[l:i] . '"'
+    let l:bounds = s:find_path_boundaries(l:lines[l:i])
+    echo '  Bounds: ' . string(l:bounds)
+    if !empty(l:bounds)
+      let [l:ps, l:pe, l:fs, l:fe] = l:bounds
+      if l:ps >= 0
+        echo '  Prefix: "' . l:lines[l:i][l:ps : l:pe] . '"'
+      else
+        echo '  Prefix: (none - root level file)'
+      endif
+      echo '  Filename: "' . l:lines[l:i][l:fs : l:fe] . '"'
+    endif
+  endfor
+
+  echo ''
+  echo '--- Synthetic tests ---'
+  " Test with a path that has directories
+  let l:test_line = ' autoload/clap/picker.vim'
+  echo 'With dir: "' . l:test_line . '"'
+  let l:bounds = s:find_path_boundaries(l:test_line)
+  if !empty(l:bounds)
+    let [l:ps, l:pe, l:fs, l:fe] = l:bounds
+    if l:ps >= 0
+      echo '  Prefix: "' . l:test_line[l:ps : l:pe] . '"'
+    endif
+    echo '  Filename: "' . l:test_line[l:fs : l:fe] . '"'
+  endif
+
+  " Test with a root-level file
+  let l:test_line2 = ' Cargo.toml'
+  echo 'Root file: "' . l:test_line2 . '"'
+  let l:bounds2 = s:find_path_boundaries(l:test_line2)
+  if !empty(l:bounds2)
+    let [l:ps, l:pe, l:fs, l:fe] = l:bounds2
+    if l:ps >= 0
+      echo '  Prefix: "' . l:test_line2[l:ps : l:pe] . '"'
+    else
+      echo '  Prefix: (none)'
+    endif
+    echo '  Filename: "' . l:test_line2[l:fs : l:fe] . '"'
+  endif
+
+  echo ''
+  echo 'ClapPathPrefix exists: ' . hlexists('ClapPathPrefix')
+  echo 'ClapFileName exists: ' . hlexists('ClapFileName')
+
+  " Check if matches are applied in the display window
+  if exists('g:clap.display.winid')
+    let l:match_ids = getwinvar(g:clap.display.winid, 'clap_path_match_ids', [])
+    echo 'Path match IDs in display window: ' . string(l:match_ids)
+  endif
+
+  echo ''
+  echo 'TIP: Type a query like "src/" or "autoload/" to see files with directory paths'
+  echo 'Run :call clap#highlighter#path#apply() to manually re-apply highlights'
+endfunction
+
+" Apply path highlighting to all visible lines in the display buffer
+function! clap#highlighter#path#apply() abort
+  if !clap#highlighter#path#should_highlight()
+    return
+  endif
+
+  let l:bufnr = g:clap.display.bufnr
+  if !bufexists(l:bufnr)
+    return
+  endif
+
+  " Clear previous path highlights
+  call s:clear_path_highlights(l:bufnr)
+
+  " Get all lines in the display buffer
+  let l:lines = getbufline(l:bufnr, 1, '$')
+
+  " Apply highlighting to each line
+  let l:lnum = 0
+  for l:line in l:lines
+    if empty(l:line) || l:line ==# g:clap_no_matches_msg
+      let l:lnum += 1
+      continue
+    endif
+
+    let l:bounds = s:find_path_boundaries(l:line)
+    if !empty(l:bounds)
+      let [l:prefix_start, l:prefix_end, l:filename_start, l:filename_end] = l:bounds
+
+      " Highlight directory prefix (dimmed) - includes the trailing /
+      if l:prefix_end > l:prefix_start
+        call s:add_path_highlight(l:bufnr, l:lnum, l:prefix_start, l:prefix_end, 'ClapPathPrefix')
+      endif
+
+      " Highlight filename (bright)
+      if l:filename_end >= l:filename_start
+        call s:add_path_highlight(l:bufnr, l:lnum, l:filename_start, l:filename_end, 'ClapFileName')
+      endif
+    endif
+
+    let l:lnum += 1
+  endfor
+endfunction
+
+" Clear path highlights
+function! clap#highlighter#path#clear() abort
+  if bufexists(g:clap.display.bufnr)
+    call s:clear_path_highlights(g:clap.display.bufnr)
+  endif
+endfunction
+
+let &cpoptions = s:save_cpo
+unlet s:save_cpo

autoload/clap/init.vim

@@ -66,12 +66,25 @@ function! s:init_fuzzy_match_hl_groups() abort
   let g:__clap_fuzzy_last_hl_group = 'ClapFuzzyMatches'.g:__clap_fuzzy_matches_hl_group_cnt
 endfunction
 
+function! s:init_path_highlight_groups() abort
+  " For Vim, we need to define text property types for path highlighting
+  if !has('nvim')
+    try
+      call prop_type_add('ClapPathPrefix', {'highlight': 'ClapPathPrefix'})
+      call prop_type_add('ClapFileName', {'highlight': 'ClapFileName'})
+    catch
+      " Types may already exist
+    endtry
+  endif
+endfunction
+
 function! clap#init#() abort
   call clap#api#clap#init()
   call clap#themes#init()
 
   call s:init_submatches_hl_group()
   call s:init_fuzzy_match_hl_groups()
+  call s:init_path_highlight_groups()
 
   " Spawn the daemon process if not running
   if !clap#job#daemon#is_running()

autoload/clap/picker.vim

@@ -32,6 +32,9 @@ function! clap#picker#init(lines, truncated_map, icon_added, using_cache) abort
   call clap#sign#ensure_exists()
   call clap#spinner#refresh()
   call clap#preview#update_with_delay()
+
+  " Apply path prefix dimming for file-related providers
+  call clap#highlighter#path#apply()
 endfunction
 
 function! clap#picker#process_progress(matched, processed) abort
@@ -88,6 +91,9 @@ function! clap#picker#update(update_info) abort
       return
     endtry
   endif
+
+  " Apply path prefix dimming for file-related providers
+  call clap#highlighter#path#apply()
 endfunction
 
 function! clap#picker#update_on_empty_query(lines, truncated_map, icon_added) abort
@@ -106,6 +112,9 @@ function! clap#picker#update_on_empty_query(lines, truncated_map, icon_added) ab
   call g:clap.display.clear_highlight()
   call clap#indicator#update_matched(0)
   call clap#preview#update_with_delay()
+
+  " Apply path prefix dimming for file-related providers
+  call clap#highlighter#path#apply()
 endfunction
 
 function! clap#picker#update_preview(preview) abort