Skip to content

Commit bcc9c1e

Browse files
committed
fix(opam): make backtrace public again in xapi-log.backtrace
When using `opam` to install all packages from XAPI some libraries failed to build because the internal `backtrace` library was only available in the `xapi-log` package. The build worked when using `dune` directly (or `koji`), because they build the entire repository instead of individual packages. To avoid conflicts with the `xapi-backtrace` installed from `xs-opam` make the backtrace library properly part of `xapi-log`, by exposing it as `xapi-log.backtrace`. Put the cram tests into the xapi-log.backtrace package too. Add rpclib as a dependency for xapi-log, it was a dependency of xapi-backtrace. Fixes: e4da294 ("[maintenance]: use internal backtrace library") Signed-off-by: Edwin Török <edwin.torok@citrix.com>
1 parent e0c8c0c commit bcc9c1e

File tree

24 files changed

+36
-31
lines changed

24 files changed

+36
-31
lines changed

dune-project

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,7 @@
235235
fmt
236236
logs
237237
mtime
238+
rpclib
238239
(xapi-stdext-pervasives (= :version))))
239240

240241
(package

ocaml/gencert/dune

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
rresult
1919
unix
2020
x509
21-
backtrace
21+
xapi-log.backtrace
2222
xapi-consts
2323
xapi-log
2424
xapi-inventory

ocaml/idl/dune

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
sexplib0
1414
sexpr
1515
threads
16-
backtrace
16+
xapi-log.backtrace
1717
xapi-consts
1818
xapi-schema
1919
clock

ocaml/libs/backtrace/lib/dune

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
(library
22
(name backtrace)
3-
(package xapi-log)
3+
(public_name xapi-log.backtrace)
44
(flags (:standard -w -39-32))
55
(libraries
66
rpclib.core rpclib.json threads.posix)

ocaml/libs/backtrace/test/dune

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
11
(library
22
(name backtrace_test_lib)
33
(modules log)
4-
(libraries backtrace)
4+
(libraries xapi-log.backtrace)
55
)
66

77
(executable
88
(name raiser)
99
(modules raiser)
10-
(libraries backtrace_test_lib backtrace)
10+
(libraries backtrace_test_lib xapi-log.backtrace)
1111
)
1212

13-
(cram (deps ./raiser.exe))
13+
(cram
14+
(package xapi-log)
15+
(deps ./raiser.exe)
16+
)

ocaml/libs/http-lib/dune

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
unix
3535
uuid
3636
uri
37-
backtrace
37+
xapi-log.backtrace
3838
xapi-consts.xapi_version
3939
xapi-idl.updates
4040
xapi-log
@@ -60,7 +60,7 @@
6060
tracing_propagator
6161
unix
6262
uri
63-
backtrace
63+
xapi-log.backtrace
6464
xapi-log
6565
xapi-stdext-pervasives
6666
xapi-stdext-threads
@@ -84,7 +84,7 @@
8484
stunnel
8585
threads.posix
8686
unix
87-
backtrace
87+
xapi-log.backtrace
8888
xapi-log
8989
xapi-stdext-pervasives
9090
xapi-stdext-unix))

ocaml/libs/log/dune

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
ptime
1414
ptime.clock
1515
threads.posix
16-
backtrace
1716
unix
17+
xapi-log.backtrace
1818
)
1919
(wrapped false)
2020
)

ocaml/libs/log/test/dune

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
(executable
22
(name log_test)
3-
(libraries log threads.posix backtrace))
3+
(libraries log threads.posix xapi-log.backtrace))
44

55
(cram
66
(package xapi-log)

ocaml/libs/open-uri/dune

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
stunnel
88
unix
99
uri
10-
backtrace
10+
xapi-log.backtrace
1111
xapi-consts
1212
xapi-log
1313
xapi-stdext-pervasives

ocaml/quicktest/dune

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
threads.posix
3131
unix
3232
uuid
33-
backtrace
33+
xapi-log.backtrace
3434
xapi-client
3535
xapi-consts
3636
xapi-datamodel

0 commit comments

Comments
 (0)