Skip to content

Commit 5531f7e

Browse files
liuxiaotongliuxiaotong
andauthored
fix(ci): add quality extra + skip tests when datasets missing (#6)
- CI needs datasets package (in quality extra) for test_cli_extended - Skip test_analyze_from_file tests when datasets not installed Co-authored-by: liuxiaotong <liuxiaotong@knowlyr.com>
1 parent 15c82a5 commit 5531f7e

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
- name: Install dependencies
2626
run: |
2727
python -m pip install --upgrade pip
28-
pip install -e ".[dev]"
28+
pip install -e ".[dev,quality]"
2929
3030
- name: Lint with ruff
3131
run: ruff check .

tests/test_local_source.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
"""Tests for local file source support (CSV, Parquet, JSONL)."""
22

33
import csv
4+
import importlib
45
import json
56
import os
67
import tempfile
78
import unittest
89
from pathlib import Path
910

11+
_has_datasets = importlib.util.find_spec("datasets") is not None
12+
1013
from click.testing import CliRunner
1114

1215
from datarecipe.analyzer import DatasetAnalyzer
@@ -294,6 +297,7 @@ def _create_csv(self):
294297
writer.writerow({"text": f"This is sample text number {i} for quality analysis testing.", "label": "pos"})
295298
return path
296299

300+
@unittest.skipUnless(_has_datasets, "requires 'datasets' package (install via pip install -e '.[quality]')")
297301
def test_analyze_from_file(self):
298302
from datarecipe.quality_metrics import QualityAnalyzer
299303

@@ -303,6 +307,7 @@ def test_analyze_from_file(self):
303307

304308
self.assertGreater(report.sample_size, 0)
305309

310+
@unittest.skipUnless(_has_datasets, "requires 'datasets' package (install via pip install -e '.[quality]')")
306311
def test_analyze_from_file_auto_detect_field(self):
307312
from datarecipe.quality_metrics import QualityAnalyzer
308313

0 commit comments

Comments
 (0)