Skip to content

Commit ccf90cc

Browse files
committed
Improve boolean defaults (#3117)
1 parent 958c91c commit ccf90cc

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/livebook/teams/requests.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ defmodule Livebook.Teams.Requests do
255255
app_folder_id: app_deployment.app_folder_id,
256256
deployment_group_id: deployment_group_id,
257257
sha: app_deployment.sha,
258-
redeploy: opts[:redeploy] || false
258+
redeploy: Keyword.get(opts, :redeploy, false)
259259
}
260260

261261
encrypted_content = Teams.encrypt(app_deployment.file, secret_key)

lib/livebook_cli/deploy.ex

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ defmodule LivebookCLI.Deploy do
6464
session_token: opts[:org_token],
6565
teams_key: opts[:teams_key],
6666
deployment_group_id: opts[:deployment_group_id],
67-
dry_run?: opts[:dry_run] || false,
68-
redeploy?: opts[:redeploy] || false
67+
dry_run?: Keyword.get(opts, :dry_run, false),
68+
redeploy?: Keyword.get(opts, :redeploy, false)
6969
}
7070
end
7171

@@ -230,7 +230,7 @@ defmodule LivebookCLI.Deploy do
230230
defp ensure_skip_on_dry_run(app_deployment, dry_run?) do
231231
if dry_run? do
232232
message = """
233-
* #{app_deployment.title} skipped due to --dry-run
233+
* #{app_deployment.title} skipped due to --dry-run
234234
"""
235235

236236
log_info(message)

0 commit comments

Comments
 (0)