brianyin/ajs-320-bump-openai-to-6.x #813
Conversation
🦋 Changeset detectedLatest commit: 3d1c719 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
toubatbrian
changed the title
| export type Expand<T> = T extends Function | ||
| ? T | ||
| : T extends object | ||
| ? T extends Array<infer U> | ||
| ? Array<Expand<U>> | ||
| : T extends Map<infer K, infer V> | ||
| ? Map<Expand<K>, Expand<V>> | ||
| : T extends Set<infer M> | ||
| ? Set<Expand<M>> | ||
| : { [K in keyof T]: Expand<T[K]> } | ||
| : T; |
There was a problem hiding this comment.
For example:
type WebSearchOptions = Expand<OpenAI.Chat.Completions.ChatCompletionCreateParams.WebSearchOptions>;When hover over WebSearchOptions in Cursor, it shows:
type WebSearchOptions = {
search_context_size?: "low" | "medium" | "high" | undefined;
user_location?: {
approximate: {
city?: string | undefined;
country?: string | undefined;
region?: string | undefined;
timezone?: string | undefined;
};
type: "approximate";
} | null | undefined;
}instead of
type WebSearchOptions = OpenAI.Chat.Completions.ChatCompletionCreateParams.WebSearchOptionsThis helps debug
| expect(calls.length).toStrictEqual(1); | ||
| expect(JSON.parse(calls[0]!.args).name).toStrictEqual('Theo'); |
There was a problem hiding this comment.
google is still outputting NULL for .optional() schema, will add a ticket and investigate it.
There was a problem hiding this comment.
I found this issue with .optional() and OpenAI as well openai/openai-node#1180, looks like a known limitation from the official docs: https://platform.openai.com/docs/guides/structured-outputs#all-fields-must-be-required
Bump openai to 6.x, Re-enable critical LLM tests to make sure nothing breaks