Skip to content

Commit 94bc274

Browse files
remove protobuf from the deps of examples (#27)
1 parent 4b58c0a commit 94bc274

File tree

2 files changed

+2
-19
lines changed

2 files changed

+2
-19
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ This SDK enables native C++ applications to connect to LiveKit servers for real-
1515

1616
### For Building the SDK:
1717
- **Windows:** Visual Studio 2019+, vcpkg
18-
- **Linux:** `sudo apt install libprotobuf-dev libssl-dev` (protobuf 3.x)
19-
- **macOS:** `brew install protobuf` (protobuf 3.x)
18+
- **Linux:** `sudo apt install ninja-build libprotobuf-dev libssl-dev` (protobuf 3.x)
19+
- **macOS:** `brew install ninja protobuf` (protobuf 3.x)
2020

2121
### For Using the Pre-built SDK:
2222
- **Windows:** ✅ All dependencies included (DLLs bundled) - ready to use

examples/CMakeLists.txt

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,6 @@ endif()
2424
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
2525
include(sdl3)
2626

27-
# Common include directories for examples that need private headers
28-
# TODO: These should be refactored to use only public headers
29-
set(EXAMPLES_PRIVATE_INCLUDE_DIRS
30-
${LIVEKIT_ROOT_DIR}/src
31-
${LIVEKIT_BINARY_DIR}/generated
32-
)
33-
3427
add_executable(SimpleRoom
3528
simple_room/main.cpp
3629
simple_room/fallback_capture.cpp
@@ -45,14 +38,10 @@ add_executable(SimpleRoom
4538
simple_room/wav_audio_source.h
4639
)
4740

48-
target_include_directories(SimpleRoom PRIVATE ${EXAMPLES_PRIVATE_INCLUDE_DIRS})
4941

50-
# Link protobuf::libprotobuf directly to get proper include directories
51-
# (livekit links it PRIVATELY so its headers aren't propagated)
5242
target_link_libraries(SimpleRoom
5343
PRIVATE
5444
livekit
55-
protobuf::libprotobuf
5645
SDL3::SDL3
5746
)
5847

@@ -107,7 +96,6 @@ target_link_libraries(SimpleRpc
10796
PRIVATE
10897
nlohmann_json::nlohmann_json
10998
livekit
110-
protobuf::libprotobuf
11199
)
112100

113101
add_executable(SimpleDataStream
@@ -119,7 +107,6 @@ target_include_directories(SimpleDataStream PRIVATE ${EXAMPLES_PRIVATE_INCLUDE_D
119107
target_link_libraries(SimpleDataStream
120108
PRIVATE
121109
livekit
122-
protobuf::libprotobuf
123110
)
124111

125112
add_custom_command(
@@ -135,13 +122,9 @@ if(WIN32)
135122
# Get the livekit library output directory (where DLLs are copied during main build)
136123
set(LIVEKIT_LIB_DIR $<TARGET_FILE_DIR:livekit>)
137124

138-
# Protobuf DLL name depends on configuration (libprotobufd.dll for Debug, libprotobuf.dll for Release)
139-
set(PROTOBUF_DLL_NAME $<IF:$<CONFIG:Debug>,libprotobufd.dll,libprotobuf.dll>)
140-
141125
# List of DLLs to copy (using generator expressions for config-dependent names)
142126
set(REQUIRED_DLLS
143127
"livekit_ffi.dll"
144-
"${PROTOBUF_DLL_NAME}"
145128
"abseil_dll.dll"
146129
)
147130

0 commit comments

Comments
 (0)