fix the warnings and remove the ignorance from flutter analyze (#906)

This PR removed some of the error ignorances from analysis_options.yaml
and fixed the warnings.

---------

Co-authored-by: Hiroshi Horie <[email protected]>

Author: xianshijing-lk

.changes/flutter-lint-warnings

@@ -0,0 +1 @@
+patch type="changed" "Re-enable Flutter lint warnings and fix existing issues"

analysis_options.yaml

@@ -21,18 +21,7 @@ analyzer:
     no_wildcard_variable_uses: ignore
     use_super_parameters: ignore
     avoid_print: ignore
-    use_build_context_synchronously: ignore
-    discarded_futures: ignore
-    prefer_final_locals: ignore
-    depend_on_referenced_packages: ignore
-
-    # Suppress noisy or harmless warnings
     deprecated_member_use_from_same_package: ignore
-    unused_element_parameter: ignore
-    unintended_html_in_doc_comment: ignore
-    implementation_imports: ignore
-    invalid_runtime_check_with_js_interop_types: ignore
-    unnecessary_import: ignore
 
   # Exclude protobuf files
   exclude:

example/analysis_options.yaml

@@ -32,11 +32,6 @@ analyzer:
     no_wildcard_variable_uses: ignore
     use_super_parameters: ignore
     avoid_print: ignore
-    use_build_context_synchronously: ignore
-    # TODO, fix the discarded_futures problems and re-enable the warnings
-    discarded_futures: ignore
-    prefer_final_locals: ignore
-    depend_on_referenced_packages: ignore
 
   # Exclude protobuf files
   exclude:

example/lib/pages/connect.dart

@@ -6,6 +6,7 @@ import 'package:livekit_example/widgets/text_field.dart';
 import 'package:shared_preferences/shared_preferences.dart';
 import 'package:permission_handler/permission_handler.dart';
 
+import 'dart:async';
 import '../exts.dart';
 
 class ConnectPage extends StatefulWidget {
@@ -43,9 +44,9 @@ class _ConnectPageState extends State<ConnectPage> {
   @override
   void initState() {
     super.initState();
-    _readPrefs();
+    unawaited(_readPrefs());
     if (lkPlatformIs(PlatformType.android)) {
-      _checkPermissions();
+      unawaited(_checkPermissions());
     }
   }
 
@@ -124,10 +125,10 @@ class _ConnectPageState extends State<ConnectPage> {
       print('Connecting with url: ${_uriCtrl.text}, '
           'token: ${_tokenCtrl.text}...');
 
-      var url = _uriCtrl.text;
-      var token = _tokenCtrl.text;
-      var e2eeKey = _sharedKeyCtrl.text;
-
+      final url = _uriCtrl.text;
+      final token = _tokenCtrl.text;
+      final e2eeKey = _sharedKeyCtrl.text;
+      if (!ctx.mounted) return;
       await Navigator.push<void>(
         ctx,
         MaterialPageRoute(
@@ -147,6 +148,7 @@ class _ConnectPageState extends State<ConnectPage> {
       );
     } catch (error) {
       print('Could not connect $error');
+      if (!ctx.mounted) return;
       await ctx.showErrorDialog(error);
     } finally {
       setState(() {

example/lib/pages/prejoin.dart

@@ -61,12 +61,12 @@ class _PreJoinPageState extends State<PreJoinPage> {
   void initState() {
     super.initState();
     _subscription = Hardware.instance.onDeviceChange.stream.listen(_loadDevices);
-    Hardware.instance.enumerateDevices().then(_loadDevices);
+    unawaited(Hardware.instance.enumerateDevices().then(_loadDevices));
   }
 
   @override
   void deactivate() {
-    _subscription?.cancel();
+    unawaited(_subscription?.cancel());
     super.deactivate();
   }
 
@@ -151,7 +151,7 @@ class _PreJoinPageState extends State<PreJoinPage> {
 
   @override
   void dispose() {
-    _subscription?.cancel();
+    unawaited(_subscription?.cancel());
     super.dispose();
   }
 
@@ -160,16 +160,16 @@ class _PreJoinPageState extends State<PreJoinPage> {
 
     setState(() {});
 
-    var args = widget.args;
+    final args = widget.args;
 
     try {
       //create new room
-      var cameraEncoding = const VideoEncoding(
+      const cameraEncoding = VideoEncoding(
         maxBitrate: 5 * 1000 * 1000,
         maxFramerate: 30,
       );
 
-      var screenEncoding = const VideoEncoding(
+      const screenEncoding = VideoEncoding(
         maxBitrate: 3 * 1000 * 1000,
         maxFramerate: 15,
       );
@@ -226,12 +226,14 @@ class _PreJoinPageState extends State<PreJoinPage> {
         ),
       );
 
+      if (!context.mounted) return;
       await Navigator.push<void>(
         context,
         MaterialPageRoute(builder: (_) => RoomPage(room, listener)),
       );
     } catch (error) {
       print('Could not connect $error');
+      if (!context.mounted) return;
       await context.showErrorDialog(error);
     } finally {
       setState(() {
@@ -243,6 +245,7 @@ class _PreJoinPageState extends State<PreJoinPage> {
   void _actionBack(BuildContext context) async {
     await _setEnableVideo(false);
     await _setEnableAudio(false);
+    if (!context.mounted) return;
     Navigator.of(context).pop();
   }
 

example/lib/pages/room.dart

@@ -44,7 +44,7 @@ class _RoomPageState extends State<RoomPage> {
     });
 
     if (lkPlatformIs(PlatformType.android)) {
-      Hardware.instance.setSpeakerphoneOn(true);
+      unawaited(Hardware.instance.setSpeakerphoneOn(true));
     }
 
     if (lkPlatformIsDesktop()) {
@@ -58,15 +58,17 @@ class _RoomPageState extends State<RoomPage> {
   @override
   void dispose() {
     // always dispose listener
-    (() async {
-      widget.room.removeListener(_onRoomDidUpdate);
-      await _listener.dispose();
-      await widget.room.dispose();
-    })();
+    widget.room.removeListener(_onRoomDidUpdate);
+    unawaited(_disposeRoomAsync());
     onWindowShouldClose = null;
     super.dispose();
   }
 
+  Future<void> _disposeRoomAsync() async {
+    await _listener.dispose();
+    await widget.room.dispose();
+  }
+
   /// for more information, see [event types](https://docs.livekit.io/client/events/#events)
   void _setUpListeners() => _listener
     ..on<RoomDisconnectedEvent>((event) async {
@@ -81,7 +83,7 @@ class _RoomPageState extends State<RoomPage> {
       _sortParticipants();
     })
     ..on<RoomRecordingStatusChanged>((event) {
-      context.showRecordingStatusChangedDialog(event.activeRecording);
+      unawaited(context.showRecordingStatusChangedDialog(event.activeRecording));
     })
     ..on<RoomAttemptReconnectEvent>((event) {
       print('Attempting to reconnect ${event.attempt}/${event.maxAttemptsRetry}, '
@@ -112,12 +114,12 @@ class _RoomPageState extends State<RoomPage> {
       } catch (err) {
         print('Failed to decode: $err');
       }
-      context.showDataReceivedDialog(decoded);
+      unawaited(context.showDataReceivedDialog(decoded));
     })
     ..on<AudioPlaybackStatusChanged>((event) async {
       if (!widget.room.canPlaybackAudio) {
         print('Audio playback failed for iOS Safari ..........');
-        bool? yesno = await context.showPlayAudioManuallyDialog();
+        final yesno = await context.showPlayAudioManuallyDialog();
         if (yesno == true) {
           await widget.room.startAudio();
         }
@@ -126,18 +128,21 @@ class _RoomPageState extends State<RoomPage> {
 
   void _askPublish() async {
     final result = await context.showPublishDialog();
+    if (!mounted) return;
     if (result != true) return;
     // video will fail when running in ios simulator
     try {
       await widget.room.localParticipant?.setCameraEnabled(true);
     } catch (error) {
       print('could not publish video: $error');
+      if (!mounted) return;
       await context.showErrorDialog(error);
     }
     try {
       await widget.room.localParticipant?.setMicrophoneEnabled(true);
     } catch (error) {
       print('could not publish audio: $error');
+      if (!mounted) return;
       await context.showErrorDialog(error);
     }
   }
@@ -151,8 +156,8 @@ class _RoomPageState extends State<RoomPage> {
   }
 
   void _sortParticipants() {
-    List<ParticipantTrack> userMediaTracks = [];
-    List<ParticipantTrack> screenTracks = [];
+    final userMediaTracks = <ParticipantTrack>[];
+    final screenTracks = <ParticipantTrack>[];
     for (var participant in widget.room.remoteParticipants.values) {
       for (var t in participant.videoTrackPublications) {
         if (t.isScreenShare) {

example/lib/widgets/controls.dart

@@ -6,6 +6,7 @@ import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_background/flutter_background.dart';
 import 'package:livekit_client/livekit_client.dart';
+// ignore: depend_on_referenced_packages
 import 'package:flutter_webrtc/flutter_webrtc.dart';
 
 import '../exts.dart';
@@ -44,12 +45,12 @@ class _ControlsWidgetState extends State<ControlsWidget> {
     _subscription = Hardware.instance.onDeviceChange.stream.listen((List<MediaDevice> devices) {
       _loadDevices(devices);
     });
-    Hardware.instance.enumerateDevices().then(_loadDevices);
+    unawaited(Hardware.instance.enumerateDevices().then(_loadDevices));
   }
 
   @override
   void dispose() {
-    _subscription?.cancel();
+    unawaited(_subscription?.cancel());
     participant.removeListener(_onChange);
     super.dispose();
   }
@@ -140,7 +141,7 @@ class _ControlsWidgetState extends State<ControlsWidget> {
           return;
         }
         print('DesktopCapturerSource: ${source.id}');
-        var track = await LocalVideoTrack.createScreenShareTrack(
+        final track = await LocalVideoTrack.createScreenShareTrack(
           ScreenShareCaptureOptions(
             sourceId: source.id,
             maxFrameRate: 15.0,
@@ -154,7 +155,7 @@ class _ControlsWidgetState extends State<ControlsWidget> {
     }
     if (lkPlatformIs(PlatformType.android)) {
       // Android specific
-      bool hasCapturePermission = await Helper.requestCapturePermission();
+      final hasCapturePermission = await Helper.requestCapturePermission();
       if (!hasCapturePermission) {
         return;
       }
@@ -187,6 +188,7 @@ class _ControlsWidgetState extends State<ControlsWidget> {
     }
 
     if (lkPlatformIsWebMobile()) {
+      if (!mounted) return;
       await context.showErrorDialog('Screen share is not supported on mobile web');
       return;
     }
@@ -218,6 +220,7 @@ class _ControlsWidgetState extends State<ControlsWidget> {
           allParticipantsAllowed: result,
         );
       } catch (error) {
+        if (!mounted) return;
         await context.showErrorDialog(error);
       }
     }

example/lib/widgets/participant.dart

@@ -3,6 +3,7 @@ import 'package:flutter/material.dart';
 import 'package:livekit_client/livekit_client.dart';
 import 'package:livekit_example/theme.dart';
 
+import 'dart:async';
 import 'no_video.dart';
 import 'participant_info.dart';
 import 'participant_stats.dart';
@@ -97,7 +98,7 @@ abstract class _ParticipantWidgetState<T extends ParticipantWidget> extends Stat
   @override
   void dispose() {
     widget.participant.removeListener(_onParticipantChanged);
-    _listener?.dispose();
+    unawaited(_listener?.dispose());
     super.dispose();
   }
 

example/lib/widgets/participant_stats.dart

@@ -1,5 +1,6 @@
 import 'package:flutter/material.dart';
 import 'package:livekit_client/livekit_client.dart';
+import 'dart:async';
 
 enum StatsType {
   kUnknown,
@@ -22,19 +23,19 @@ class _ParticipantStatsWidgetState extends State<ParticipantStatsWidget> {
   Map<String, Map<String, String>> stats = {'audio': {}, 'video': {}};
 
   void _setUpListener(Track track) {
-    var listener = track.createListener();
+    final listener = track.createListener();
     listeners.add(listener);
     if (track is LocalVideoTrack) {
       statsType = StatsType.kLocalVideoSender;
       listener.on<VideoSenderStatsEvent>((event) {
-        Map<String, String> stats = {};
+        final stats = <String, String>{};
         setState(() {
           stats['tx'] = 'total sent ${event.currentBitrate.toInt()} kpbs';
           event.stats.forEach((key, value) {
             stats['layer-$key'] =
                 '${value.frameWidth ?? 0}x${value.frameHeight ?? 0} ${value.framesPerSecond?.toDouble() ?? 0} fps, ${event.bitrateForLayers[key] ?? 0} kbps';
           });
-          var firstStats = event.stats['f'] ?? event.stats['h'] ?? event.stats['q'];
+          final firstStats = event.stats['f'] ?? event.stats['h'] ?? event.stats['q'];
           if (firstStats != null) {
             stats['encoder'] = firstStats.encoderImplementation ?? '';
             if (firstStats.mimeType != null) {
@@ -50,7 +51,7 @@ class _ParticipantStatsWidgetState extends State<ParticipantStatsWidget> {
     } else if (track is RemoteVideoTrack) {
       statsType = StatsType.kRemoteVideoReceiver;
       listener.on<VideoReceiverStatsEvent>((event) {
-        Map<String, String> stats = {};
+        final stats = <String, String>{};
         setState(() {
           if (!event.currentBitrate.isNaN) {
             stats['rx'] = '${event.currentBitrate.toInt()} kpbs';
@@ -75,7 +76,7 @@ class _ParticipantStatsWidgetState extends State<ParticipantStatsWidget> {
     } else if (track is LocalAudioTrack) {
       statsType = StatsType.kLocalAudioSender;
       listener.on<AudioSenderStatsEvent>((event) {
-        Map<String, String> stats = {};
+        final stats = <String, String>{};
         setState(() {
           stats['tx'] = '${event.currentBitrate.toInt()} kpbs';
           if (event.stats.mimeType != null) {
@@ -88,7 +89,7 @@ class _ParticipantStatsWidgetState extends State<ParticipantStatsWidget> {
     } else if (track is RemoteAudioTrack) {
       statsType = StatsType.kRemoteAudioReceiver;
       listener.on<AudioReceiverStatsEvent>((event) {
-        Map<String, String> stats = {};
+        final stats = <String, String>{};
         setState(() {
           stats['rx'] = '${event.currentBitrate.toInt()} kpbs';
           if (event.stats.mimeType != null) {
@@ -109,7 +110,7 @@ class _ParticipantStatsWidgetState extends State<ParticipantStatsWidget> {
 
   _onParticipantChanged() {
     for (var element in listeners) {
-      element.dispose();
+      unawaited(element.dispose());
     }
     listeners.clear();
     for (var track in [...widget.participant.videoTrackPublications, ...widget.participant.audioTrackPublications]) {
@@ -130,7 +131,7 @@ class _ParticipantStatsWidgetState extends State<ParticipantStatsWidget> {
   @override
   void deactivate() {
     for (var element in listeners) {
-      element.dispose();
+      unawaited(element.dispose());
     }
     widget.participant.removeListener(_onParticipantChanged);
     super.deactivate();