Skip to content

Commit cd05869

Browse files
authored
fix: fix monitorStats not started when sender == null. (#606)
* fix: fix monitorStats not start when sender == null. * set some log levels to lower. * update.
1 parent 588e898 commit cd05869

File tree

7 files changed

+6
-7
lines changed

7 files changed

+6
-7
lines changed

example/lib/pages/room.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ class _RoomPageState extends State<RoomPage> {
8787
(timeStamp) => Navigator.popUntil(context, (route) => route.isFirst));
8888
})
8989
..on<ParticipantEvent>((event) {
90-
print('Participant event');
9190
// sort participants on many track events as noted in documentation linked above
9291
_sortParticipants();
9392
})

lib/src/core/room.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ class Room extends DisposableChangeNotifier with EventsEmittable<RoomEvent> {
137137

138138
// Any event emitted will trigger ChangeNotifier
139139
events.listen((event) {
140-
logger.fine('[RoomEvent] $event, will notifyListeners()');
140+
logger.finer('[RoomEvent] $event, will notifyListeners()');
141141
notifyListeners();
142142
});
143143

lib/src/participant/participant.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ abstract class Participant<T extends TrackPublication>
140140
}) : _name = name {
141141
// Any event emitted will trigger ChangeNotifier
142142
events.listen((event) {
143-
logger.fine('[ParticipantEvent] $event, will notifyListeners()');
143+
logger.finer('[ParticipantEvent] $event, will notifyListeners()');
144144
notifyListeners();
145145
});
146146

lib/src/publication/remote.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ class RemoteTrackPublication<T extends RemoteTrack>
213213
);
214214

215215
newValue.onVideoViewBuild = (_) {
216-
logger.fine('[Visibility] VideoView did build');
216+
logger.finer('[Visibility] VideoView did build');
217217
if (_lastSentTrackSettings?.disabled == true) {
218218
// quick enable
219219
_cancelPendingTrackSettingsUpdateRequest?.call();

lib/src/track/local/audio.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class LocalAudioTrack extends LocalTrack
5252

5353
@override
5454
Future<bool> monitorStats() async {
55-
if (sender == null || events.isDisposed || !isActive) {
55+
if (events.isDisposed || !isActive) {
5656
_currentBitrate = 0;
5757
return false;
5858
}

lib/src/track/local/video.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ class LocalVideoTrack extends LocalTrack with VideoTrack {
6767

6868
@override
6969
Future<bool> monitorStats() async {
70-
if (sender == null || events.isDisposed || !isActive) {
70+
if (events.isDisposed || !isActive) {
7171
_currentBitrate = 0;
7272
return false;
7373
}

lib/src/track/track.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ abstract class Track extends DisposableChangeNotifier
6363
{this.receiver}) {
6464
// Any event emitted will trigger ChangeNotifier
6565
events.listen((event) {
66-
logger.fine('[TrackEvent] $event, will notifyListeners()');
66+
logger.finer('[TrackEvent] $event, will notifyListeners()');
6767
notifyListeners();
6868
});
6969

0 commit comments

Comments
 (0)