Skip to content

Commit 254b19a

Browse files
authored
Prevent unintentional property overrides in createLocalAudioTrack's constraint flags (#1744)
1 parent 72499a7 commit 254b19a

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

.changeset/violet-plants-wear.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'livekit-client': patch
3+
---
4+
5+
fix(LocalTrackAudio): prevent overwriting constraint flags

src/room/track/create.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,13 @@ export async function createLocalTracks(
7878
deviceId: { ideal: deviceId },
7979
};
8080
}
81-
if (
82-
internalOptions.audio === true ||
83-
(typeof internalOptions.audio === 'object' && !internalOptions.audio.deviceId)
84-
) {
81+
if (internalOptions.audio === true) {
8582
internalOptions.audio = { deviceId: 'default' };
83+
} else if (typeof internalOptions.audio === 'object' && internalOptions.audio !== null) {
84+
internalOptions.audio = {
85+
...internalOptions.audio,
86+
deviceId: internalOptions.audio.deviceId || 'default',
87+
};
8688
}
8789
if (internalOptions.video === true) {
8890
internalOptions.video = { deviceId: 'default' };

0 commit comments

Comments
 (0)