fix: ensure offerId is only increased when offers are actually generated (#1585)

Author: lukasIO

.changeset/hip-spiders-return.md

@@ -0,0 +1,5 @@
+---
+"livekit-client": patch
+---
+
+fix: ensure offerId is only increased when offers are actually generated

src/room/PCTransport.ts

@@ -258,10 +258,6 @@ export default class PCTransport extends EventEmitter {
     const unlock = await this.offerLock.lock();
 
     try {
-      // increase the offer id at the start to ensure the offer is always > 0 so that we can use 0 as a default value for legacy behavior
-      const offerId = this.latestOfferId + 1;
-      this.latestOfferId = offerId;
-
       if (this.onOffer === undefined) {
         return;
       }
@@ -290,6 +286,9 @@ export default class PCTransport extends EventEmitter {
 
       // actually negotiate
       this.log.debug('starting to negotiate', this.logContext);
+      // increase the offer id at the start to ensure the offer is always > 0 so that we can use 0 as a default value for legacy behavior
+      const offerId = this.latestOfferId + 1;
+      this.latestOfferId = offerId;
       const offer = await this.pc.createOffer(options);
       this.log.debug('original offer', { sdp: offer.sdp, ...this.logContext });