Make sure logger is initialized when output is created (#415)

On creation output registers itself to receive EOS signals first and then creates logger - which leaves a small gap during which if EOS comes - logger is not initialized leading to panics. Fixing this by making sure logger is always created upfront.

Author: milos-lk

pkg/media/output.go

@@ -87,13 +87,12 @@ type AudioOutput struct {
 }
 
 func NewVideoOutput(codec livekit.VideoCodec, layer *livekit.VideoLayer, outputSync *utils.TrackOutputSynchronizer, isPlayingTooSlow func() bool, statsGatherer *stats.LocalMediaStatsGatherer, eos *eosDispatcher) (*VideoOutput, error) {
-	e, err := newVideoOutput(codec, outputSync, isPlayingTooSlow, eos)
+	log := logger.GetLogger().WithValues("kind", "video", "layer", layer.Quality.String())
+	e, err := newVideoOutput(codec, outputSync, isPlayingTooSlow, eos, log)
 	if err != nil {
 		return nil, err
 	}
 
-	e.logger = logger.GetLogger().WithValues("kind", "video", "layer", layer.Quality.String())
-
 	e.trackStatsGatherer = statsGatherer.RegisterTrackStats(fmt.Sprintf("%s.%s", stats.OutputVideo, layer.Quality.String()))
 
 	e.latencyCaps = gst.NewCapsFromString(packetLatencyCaps)
@@ -251,13 +250,12 @@ func NewVideoOutput(codec livekit.VideoCodec, layer *livekit.VideoLayer, outputS
 }
 
 func NewAudioOutput(options *livekit.IngressAudioEncodingOptions, outputSync *utils.TrackOutputSynchronizer, isPlayingTooSlow func() bool, statsGatherer *stats.LocalMediaStatsGatherer, eos *eosDispatcher) (*AudioOutput, error) {
-	e, err := newAudioOutput(options.AudioCodec, outputSync, isPlayingTooSlow, eos)
+	log := logger.GetLogger().WithValues("kind", "audio")
+	e, err := newAudioOutput(options.AudioCodec, outputSync, isPlayingTooSlow, eos, log)
 	if err != nil {
 		return nil, err
 	}
 
-	e.logger = logger.GetLogger().WithValues("kind", "audio")
-
 	e.trackStatsGatherer = statsGatherer.RegisterTrackStats(stats.OutputAudio)
 
 	audioConvert, err := gst.NewElement("audioconvert")
@@ -356,8 +354,8 @@ func NewAudioOutput(options *livekit.IngressAudioEncodingOptions, outputSync *ut
 	return e, nil
 }
 
-func newVideoOutput(codec livekit.VideoCodec, outputSync *utils.TrackOutputSynchronizer, isPlayingTooSlow func() bool, eos *eosDispatcher) (*VideoOutput, error) {
-	e, err := newOutput(outputSync, isPlayingTooSlow, eos)
+func newVideoOutput(codec livekit.VideoCodec, outputSync *utils.TrackOutputSynchronizer, isPlayingTooSlow func() bool, eos *eosDispatcher, log logger.Logger) (*VideoOutput, error) {
+	e, err := newOutput(outputSync, isPlayingTooSlow, eos, log)
 	if err != nil {
 		return nil, err
 	}
@@ -375,8 +373,8 @@ func newVideoOutput(codec livekit.VideoCodec, outputSync *utils.TrackOutputSynch
 	return o, nil
 }
 
-func newAudioOutput(codec livekit.AudioCodec, outputSync *utils.TrackOutputSynchronizer, isPlayingTooSlow func() bool, eos *eosDispatcher) (*AudioOutput, error) {
-	e, err := newOutput(outputSync, isPlayingTooSlow, eos)
+func newAudioOutput(codec livekit.AudioCodec, outputSync *utils.TrackOutputSynchronizer, isPlayingTooSlow func() bool, eos *eosDispatcher, log logger.Logger) (*AudioOutput, error) {
+	e, err := newOutput(outputSync, isPlayingTooSlow, eos, log)
 	if err != nil {
 		return nil, err
 	}
@@ -394,18 +392,23 @@ func newAudioOutput(codec livekit.AudioCodec, outputSync *utils.TrackOutputSynch
 	return o, nil
 }
 
-func newOutput(outputSync *utils.TrackOutputSynchronizer, isPlayingTooSlow func() bool, eos *eosDispatcher) (*Output, error) {
+func newOutput(outputSync *utils.TrackOutputSynchronizer, isPlayingTooSlow func() bool, eos *eosDispatcher, log logger.Logger) (*Output, error) {
 	sink, err := app.NewAppSink()
 	if err != nil {
 		return nil, err
 	}
 
+	if log == nil {
+		log = logger.GetLogger().WithValues("kind", "output")
+	}
+
 	e := &Output{
 		queue:            utils.NewBlockingQueue[*sample](queueCapacity),
 		sink:             sink,
 		outputSync:       outputSync,
 		isPlayingTooSlow: isPlayingTooSlow,
 		eos:              eos,
+		logger:           log,
 	}
 
 	if e.eos != nil {