Skip to content

Commit 29a3aca

Browse files
Replay updates (#1199)
* replay updates * generated protobuf --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 8df51f0 commit 29a3aca

File tree

4 files changed

+413
-344
lines changed

4 files changed

+413
-344
lines changed
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
name: PR Slack Notifier
2+
3+
on:
4+
pull_request:
5+
types: [review_requested, reopened, closed]
6+
pull_request_review:
7+
types: [submitted]
8+
9+
permissions:
10+
contents: read
11+
pull-requests: write
12+
issues: write
13+
14+
concurrency:
15+
group: pr-slack-${{ github.event.pull_request.number }}-${{ github.workflow }}
16+
cancel-in-progress: false
17+
18+
jobs:
19+
notify-devs:
20+
runs-on: ubuntu-latest
21+
steps:
22+
- uses: livekit/slack-notifier-action@main
23+
with:
24+
config_json: ${{ secrets.SLACK_NOTIFY_CONFIG_JSON }}
25+
slack_token: ${{ secrets.SLACK_PR_NOTIFIER_TOKEN }}

protobufs/cloud_replay.proto

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,41 +11,47 @@ import "google/protobuf/empty.proto";
1111
// Experimental (not currently available)
1212
service Replay {
1313
rpc ListReplays(ListReplaysRequest) returns (ListReplaysResponse);
14-
rpc LoadReplay(LoadReplayRequest) returns (LoadReplayResponse);
15-
rpc SeekForRoom(RoomSeekRequest) returns (google.protobuf.Empty);
16-
rpc CloseReplay(CloseReplayRequest) returns (google.protobuf.Empty);
1714
rpc DeleteReplay(DeleteReplayRequest) returns (google.protobuf.Empty);
15+
16+
rpc Playback(PlaybackRequest) returns (PlaybackResponse);
17+
rpc Seek(SeekRequest) returns (google.protobuf.Empty);
18+
rpc Close(ClosePlaybackRequest) returns (google.protobuf.Empty);
1819
}
1920

20-
message ListReplaysRequest {}
21+
message ListReplaysRequest {
22+
string room_name = 1; // optional
23+
}
2124

2225
message ListReplaysResponse {
2326
repeated ReplayInfo replays = 1;
2427
}
2528

2629
message ReplayInfo {
2730
string replay_id = 1;
31+
string room_name = 2;
32+
int64 start_time = 3;
33+
int64 duration = 4;
2834
}
2935

30-
message LoadReplayRequest {
36+
message DeleteReplayRequest {
3137
string replay_id = 1;
32-
string room_name = 2;
33-
int64 starting_pts = 3;
3438
}
3539

36-
message LoadReplayResponse {
37-
string playback_id = 1;
40+
message PlaybackRequest {
41+
string replay_id = 1;
42+
string room_name = 2; // room to play into
43+
int64 start_time = 3; // initial cursor
3844
}
3945

40-
message RoomSeekRequest {
46+
message PlaybackResponse {
4147
string playback_id = 1;
42-
int64 pts = 2;
4348
}
4449

45-
message CloseReplayRequest {
50+
message SeekRequest {
4651
string playback_id = 1;
52+
int64 start_time = 2; // initial cursor
4753
}
4854

49-
message DeleteReplayRequest {
50-
string replay_id = 1;
55+
message ClosePlaybackRequest {
56+
string playback_id = 1;
5157
}

0 commit comments

Comments
 (0)