comment + changeset

alexlivekit · alexlivekit · commit d34d3d874194 · 2025-11-13T13:46:59.000-08:00
diff --git a/.changeset/rich-places-move.md b/.changeset/rich-places-move.md
@@ -0,0 +1,5 @@
+---
+"github.com/livekit/protocol": patch
+---
+
+Adding more SIP return codes and updating SIP-to-Twirp return code mapping
diff --git a/livekit/sip.go b/livekit/sip.go
@@ -134,7 +134,7 @@ func (p *SIPStatus) GRPCStatus() *status.Status {
 		} else if code < 500 {
 			code = codes.InvalidArgument
 		} else if code < 600 {
-			code = codes.Internal
+			code = codes.FailedPrecondition // 5xx from remote server, per guideline (c) in gRPC docs
 		} else if code < 700 {
 			code = codes.InvalidArgument // Same as 4xx ,but authoratative
 		}

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"github.com/livekit/protocol": patch
 +---
++
 +Adding more SIP return codes and updating SIP-to-Twirp return code mapping
Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ func (p SIPStatus) GRPCStatus() status.Status {`
`134`	`134`	`} else if code < 500 {`
`135`	`135`	`code = codes.InvalidArgument`
`136`	`136`	`} else if code < 600 {`
`137`		`- code = codes.Internal`
	`137`	`+ code = codes.FailedPrecondition // 5xx from remote server, per guideline (c) in gRPC docs`
`138`	`138`	`} else if code < 700 {`
`139`	`139`	`code = codes.InvalidArgument // Same as 4xx ,but authoratative`
`140`	`140`	`}`