Skip to content

Commit e430b4b

Browse files
authored
Add flag to make CreateSIPParticipant synchronous. (#952)
1 parent 2e0a35e commit e430b4b

File tree

9 files changed

+358
-287
lines changed

9 files changed

+358
-287
lines changed

.changeset/perfect-forks-draw.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@livekit/protocol": minor
3+
"github.com/livekit/protocol": minor
4+
---
5+
6+
Add flag to make CreateSIPParticipant synchronous.

livekit/livekit_sip.pb.go

Lines changed: 17 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

livekit/livekit_sip.twirp.go

Lines changed: 176 additions & 174 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

protobufs/livekit_sip.proto

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,10 @@ message CreateSIPParticipantRequest {
510510
bool krisp_enabled = 14;
511511

512512
SIPMediaEncryption media_encryption = 18;
513-
// NEXT ID: 19
513+
514+
// Wait for the answer for the call before returning.
515+
bool wait_until_answered = 19;
516+
// NEXT ID: 20
514517
}
515518

516519
message SIPParticipantInfo {

protobufs/rpc/sip.proto

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,19 @@ message InternalCreateSIPParticipantRequest {
101101

102102
livekit.SIPMediaEncryption media_encryption = 28;
103103

104-
// NEXT ID: 29
104+
// Wait for the answer for the call before returning.
105+
bool wait_until_answered = 29;
106+
107+
// NEXT ID: 30
105108
}
106109

107110
message InternalCreateSIPParticipantResponse {
108111
string participant_id = 1;
109112
string participant_identity = 2;
110113
string sip_call_id = 3;
114+
115+
uint32 sip_failure_code = 4;
116+
string sip_failure_reason = 5;
111117
}
112118

113119
message InternalTransferSIPParticipantRequest {

rpc/sip.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ func NewCreateSIPParticipantRequest(
101101
RingingTimeout: req.RingingTimeout,
102102
MaxCallDuration: req.MaxCallDuration,
103103
MediaEncryption: enc,
104+
WaitUntilAnswered: req.WaitUntilAnswered,
104105
}, nil
105106
}
106107

rpc/sip.pb.go

Lines changed: 76 additions & 43 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)