pr feedback

Author: anunaym14

connector/errors.go

@@ -17,11 +17,12 @@ package connector
 import "github.com/livekit/psrpc"
 
 var (
-	ErrMissingWhatsAppPhoneNumberId = psrpc.NewErrorf(psrpc.InvalidArgument, "whatsapp phone number id is required")
-	ErrMissingWhatsAppToNumber      = psrpc.NewErrorf(psrpc.InvalidArgument, "whatsapp to_phone_number is required")
-	ErrMissingWhatsAppCallId        = psrpc.NewErrorf(psrpc.InvalidArgument, "whatsapp call id is required")
-	ErrMissingWhatsAppApiKey        = psrpc.NewErrorf(psrpc.InvalidArgument, "whatsapp api key is required")
-	ErrIncorrectSDPType             = psrpc.NewErrorf(psrpc.InvalidArgument, "incorrect sdp type")
-	ErrConnectorNotFound            = psrpc.NewErrorf(psrpc.NotFound, "connector not found")
-	ErrWhatsAppCallNotFound         = psrpc.NewErrorf(psrpc.NotFound, "whatsapp call not found")
+	ErrMissingWhatsAppPhoneNumberId        = psrpc.NewErrorf(psrpc.InvalidArgument, "whatsapp phone number id is required")
+	ErrMissingWhatsAppToNumber             = psrpc.NewErrorf(psrpc.InvalidArgument, "whatsapp to_phone_number is required")
+	ErrMissingWhatsAppCallId               = psrpc.NewErrorf(psrpc.InvalidArgument, "whatsapp call id is required")
+	ErrMissingWhatsAppApiKey               = psrpc.NewErrorf(psrpc.InvalidArgument, "whatsapp api key is required")
+	ErrIncorrectSDPType                    = psrpc.NewErrorf(psrpc.InvalidArgument, "incorrect sdp type")
+	ErrConnectorNotFound                   = psrpc.NewErrorf(psrpc.NotFound, "connector not found")
+	ErrWhatsAppCallNotFound                = psrpc.NewErrorf(psrpc.NotFound, "whatsapp call not found")
+	ErrWhatsAppCloudApiVersionNotSupported = psrpc.NewErrorf(psrpc.InvalidArgument, "whatsapp cloud api version not supported")
 )

protobufs/livekit_connector_whatsapp.proto

@@ -29,6 +29,8 @@ message DialWhatsAppCallRequest {
   string whatsapp_to_phone_number = 2;
   // The API key of the business that is initiating the call
   string whatsapp_api_key = 3;
+  // WhatsApp Cloud API version, 23.0 and 24.0 are supported as of today
+  string whatsapp_cloud_api_version = 12;
   // An arbitrary string you can pass in that is useful for tracking and logging purposes.
   string whatsapp_biz_opaque_callback_data = 4;
   // What LiveKit room should this participant be connected too
@@ -45,8 +47,7 @@ message DialWhatsAppCallRequest {
   map<string, string> participant_attributes = 10;
   // Country where the call terminates as ISO 3166-1 alpha-2 (https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2). This will be used by the livekit infrastructure to route calls.
   string destination_country = 11;
-  // Meta cloud API version 
-  float whatsapp_cloud_api_version = 12;
+  // Next - 13
 }
 
 message DialWhatsAppCallResponse {
@@ -79,6 +80,8 @@ message AcceptWhatsAppCallRequest {
   string whatsapp_phone_number_id = 1;
   // The API key of the business that is connecting the call
   string whatsapp_api_key = 2;
+  // WhatsApp Cloud API version, 23.0 and 24.0 are supported as of today
+  string whatsapp_cloud_api_version = 13;
   // Call ID sent by Meta
   string whatsapp_call_id = 3;
   // An arbitrary string you can pass in that is useful for tracking and logging purposes.
@@ -100,8 +103,7 @@ message AcceptWhatsAppCallRequest {
   map<string, string> participant_attributes = 11;
   // Country where the call terminates as ISO 3166-1 alpha-2 (https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2). This will be used by the livekit infrastructure to route calls.
   string destination_country = 12;
-  // Meta cloud API version
-  float whatsapp_cloud_api_version = 13;
+  // Next - 14
 }
 
 message AcceptWhatsAppCallResponse {