Fix NPE when inbound close races with ack. (#373)

dennwc · web-flow · commit fc440e80c3da · 2025-05-25T14:10:42.000+03:00
diff --git a/pkg/sip/outbound.go b/pkg/sip/outbound.go
@@ -836,6 +836,9 @@ func (c *sipOutbound) AckInviteOK(ctx context.Context) error {
 	defer span.End()
 	c.mu.Lock()
 	defer c.mu.Unlock()
+	if c.invite == nil || c.inviteOk == nil {
+		return errors.New("call already closed")
+	}
 	return c.c.sipCli.WriteRequest(sip.NewAckRequest(c.invite, c.inviteOk, nil))
 }
 

Original file line number	Diff line number	Diff line change
`@@ -836,6 +836,9 @@ func (c *sipOutbound) AckInviteOK(ctx context.Context) error {`
`836`	`836`	`defer span.End()`
`837`	`837`	`c.mu.Lock()`
`838`	`838`	`defer c.mu.Unlock()`
	`839`	`+ if c.invite == nil \|\| c.inviteOk == nil {`
	`840`	`+ return errors.New("call already closed")`
	`841`	`+ }`
`839`	`842`	`return c.c.sipCli.WriteRequest(sip.NewAckRequest(c.invite, c.inviteOk, nil))`
`840`	`843`	`}`
`841`	`844`