functional checkpoint before cleanup

Author: eliteprox

runner/app/live/pipelines/comfyui.py

@@ -106,6 +106,8 @@ async def initialize(self, **params):
         logging.info(f"Initializing ComfyUI Pipeline with prompt: {new_params.prompt}")
 
         # Get dimensions from workflow if it's a dict
+        width = params.get('width')
+        height = params.get('height')
 
         if width is None or height is None:
             if isinstance(new_params.prompt, dict):

runner/app/live/streamer/protocol/trickle.py

@@ -29,6 +29,9 @@ async def start(self, params: dict = None):
         self.publish_queue = queue.Queue[OutputFrame]()
         metadata_cache = LastValueCache[dict]() # to pass video metadata from decoder to encoder
 
+        if params is None:
+            params = {}
+
         #TODO fix this default value issue
         output_width = params.get('width', 512)
         output_height = params.get('height', 512)

runner/app/live/streamer/streamer.py

@@ -46,6 +46,9 @@ async def start(self, params: dict):
             self.request_id, self.stream_id, params, self
         )
 
+        if params is None:
+            params = {}
+            
         params['width'] = params.get('width', self.output_width)
         params['height'] = params.get('height', self.output_height)
 
@@ -58,11 +61,12 @@ async def start(self, params: dict):
             run_in_background("ingress_loop", self.run_ingress_loop()),
             run_in_background("egress_loop", self.run_egress_loop()),
             run_in_background("report_status_loop", self.report_status_loop()),
-            run_in_background("control_loop", self.run_control_loop()),
         ]
         # auxiliary tasks that are not critical to the supervisor, but which we want to run
         # TODO: maybe remove this since we had to move the control loop to main tasks
-        self.auxiliary_tasks: list[asyncio.Task] = []
+        self.auxiliary_tasks: list[asyncio.Task] = [
+            run_in_background("control_loop", self.run_control_loop()),
+        ]
         self.tasks_supervisor_task = run_in_background(
             "tasks_supervisor", self.tasks_supervisor()
         )