ignore errcheck lint

Author: mjh1

.golangci.yml

@@ -0,0 +1,14 @@
+version: "2"
+
+linters-settings:
+  errcheck:
+    # Don't check for Close() errors in defers
+    exclude-functions:
+      - '(net/http).(*Response).Body.Close'
+      - "(database/sql).(*Rows).Close"
+      - "(os).Remove"
+      - "(os).RemoveAll"
+      - "(*os.File).Close"
+      - "(*bytes.Reader).Close"
+      - "(*io.PipeWriter).Close"
+      - "(io.ReadCloser).Close"

balancer/catabalancer/catalyst_balancer.go

@@ -339,7 +339,7 @@ func (c *CataBalancer) refreshNodes(ctx context.Context) (stats, error) {
 	if err != nil {
 		return s, fmt.Errorf("failed to query node stats: %w", err)
 	}
-	defer rows.Close()
+	defer rows.Close() // nolint:errcheck
 
 	// Process the result set
 	for rows.Next() {

balancer/mist/mist_balancer.go

@@ -176,7 +176,7 @@ func (b *MistBalancer) changeLoadBalancerServers(ctx context.Context, server, ac
 		glog.Errorf("Error making request: %v", err)
 		return nil, err
 	}
-	defer resp.Body.Close()
+	defer resp.Body.Close() // nolint:errcheck
 
 	bytes, err := io.ReadAll(resp.Body)
 
@@ -212,7 +212,7 @@ func (b *MistBalancer) getMistLoadBalancerServers(ctx context.Context) (map[stri
 		glog.Errorf("Error making request: %v", err)
 		return nil, err
 	}
-	defer resp.Body.Close()
+	defer resp.Body.Close() // nolint:errcheck
 
 	if resp.StatusCode != http.StatusOK {
 		b, _ := io.ReadAll(resp.Body)
@@ -473,7 +473,7 @@ func (b *MistBalancer) mistUtilLoadRequest(ctx context.Context, route, stream, l
 	if err != nil {
 		return "", err
 	}
-	defer resp.Body.Close()
+	defer resp.Body.Close() // nolint:errcheck
 
 	if resp.StatusCode != http.StatusOK {
 		return "", fmt.Errorf("GET request '%s' failed with http status code %d", murl, resp.StatusCode)

c2pa/c2pa_test.go

@@ -19,7 +19,7 @@ func TestSign(t *testing.T) {
 
 	outFile := "test/tiny_output_signed.mp4"
 	c := NewC2PA("es256", "test/es256_private.key", "test/es256_certs.pem")
-	defer os.Remove(outFile)
+	defer os.Remove(outFile) // nolint:errcheck
 
 	err = c.SignFile("test/tiny.mp4", outFile, "Tiny", "")
 
@@ -38,7 +38,7 @@ func TestSignWithParent(t *testing.T) {
 
 	outFile := "test/tiny_cut_output_signed.mp4"
 	c := NewC2PA("es256", "test/es256_private.key", "test/es256_certs.pem")
-	defer os.Remove(outFile)
+	defer os.Remove(outFile) // nolint:errcheck
 
 	err = c.SignFile("test/tiny_cut.mp4", outFile, "Tiny", "test/tiny_signed.mp4")
 

clients/broadcaster_remote.go

@@ -84,7 +84,7 @@ func findBroadcaster(c Credentials) (BroadcasterList, error) {
 	if err != nil {
 		return BroadcasterList{}, fmt.Errorf("http do(%s): %v", requestURL, err)
 	}
-	defer res.Body.Close()
+	defer res.Body.Close() // nolint:errcheck
 
 	if !httpOk(res.StatusCode) {
 		return BroadcasterList{}, fmt.Errorf("http GET(%s) returned %d %s", requestURL, res.StatusCode, res.Status)
@@ -130,7 +130,7 @@ func CreateStream(c Credentials, streamName string, profiles []video.EncodedProf
 	if err != nil {
 		return "", fmt.Errorf("http do(%s): %v", requestURL, err)
 	}
-	defer res.Body.Close()
+	defer res.Body.Close() // nolint:errcheck
 
 	if !httpOk(res.StatusCode) {
 		return "", fmt.Errorf("http POST(%s) returned %d %s", requestURL, res.StatusCode, res.Status)
@@ -164,7 +164,7 @@ func ReleaseManifestID(c Credentials, manifestId string) error {
 	if err != nil {
 		return fmt.Errorf("Releasing Manifest ID failed. URL: %s, manifestID: %s, err: %s", requestURL, manifestId, err)
 	}
-	defer res.Body.Close()
+	defer res.Body.Close() // nolint:errcheck
 
 	if !httpOk(res.StatusCode) {
 		return fmt.Errorf("Releasing Manifest ID failed. URL: %s, manifestID: %s, HTTP Code: %s", requestURL, manifestId, res.Status)

clients/manifest.go

@@ -77,7 +77,7 @@ func RecordingBackupCheck(requestID string, primaryManifestURL, osTransferURL *u
 			var rc io.ReadCloser
 			rc, actualSegURL, err = GetFileWithBackup(context.Background(), requestID, segURL.String(), dStorage)
 			if rc != nil {
-				rc.Close()
+				rc.Close() // nolint:errcheck
 			}
 			return err
 		}, DownloadRetryBackoff())
@@ -189,7 +189,7 @@ func downloadManifest(requestID, sourceManifestOSURL string) (playlist m3u8.Play
 			}
 			return err
 		}
-		defer rc.Close()
+		defer rc.Close() // nolint:errcheck
 
 		data := new(bytes.Buffer)
 		_, err = data.ReadFrom(rc)
@@ -390,7 +390,7 @@ func ClipInputManifest(requestID, sourceURL, clipTargetUrl string, startTimeUnix
 	if err != nil {
 		return nil, fmt.Errorf("error clipping: failed to create temp clipping storage dir: %w", err)
 	}
-	defer os.RemoveAll(clipStorageDir)
+	defer os.RemoveAll(clipStorageDir) // nolint:errcheck
 
 	// Download start/end segments and clip
 	for i, v := range segsToClip {
@@ -451,7 +451,7 @@ func ClipInputManifest(requestID, sourceURL, clipTargetUrl string, startTimeUnix
 		if err != nil {
 			return nil, fmt.Errorf("error clipping: failed to open clipped segment %d: %w", v.SeqId, err)
 		}
-		defer clippedSegmentFile.Close()
+		defer clippedSegmentFile.Close() // nolint:errcheck
 
 		clippedSegmentOSFilename := "clip_" + strconv.FormatUint(v.SeqId, 10) + ".ts"
 		err = UploadToOSURL(clipTargetUrl, clippedSegmentOSFilename, clippedSegmentFile, MaxCopyFileDuration)
@@ -553,7 +553,7 @@ func GetFirstRenditionURL(requestID string, masterManifestURL *url.URL) (*url.UR
 		if err != nil {
 			return fmt.Errorf("error downloading manifest %s: %w", masterManifestURL.Redacted(), err)
 		}
-		defer rc.Close()
+		defer rc.Close() // nolint:errcheck
 
 		playlist, playlistType, err = m3u8.DecodeFrom(rc, true)
 		if err != nil {