downloader: do atomic renaming of new binaries

iameli · iameli · commit f0d091923aa9 · 2023-10-18T14:42:20.000-07:00
diff --git a/cmd/downloader/downloader/downloader.go b/cmd/downloader/downloader/downloader.go
@@ -163,6 +163,7 @@ func ExtractTarGzipArchive(archiveFile, extractPath string, service *types.Servi
 			if output == "" {
 				output = filepath.Join(extractPath, path.Base(header.Name))
 			}
+			output = output + "-new"
 			glog.V(9).Infof("extracting to %q", output)
 			outfile, err := os.Create(output)
 			if err != nil {
@@ -176,6 +177,7 @@ func ExtractTarGzipArchive(archiveFile, extractPath string, service *types.Servi
 			}
 			outfile.Chmod(fs.FileMode(header.Mode))
 			outfile.Close()
+			os.Rename(output, filepath.Join(extractPath, path.Base(header.Name)))
 		}
 	}
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -163,6 +163,7 @@ func ExtractTarGzipArchive(archiveFile, extractPath string, service *types.Servi`
`163`	`163`	`if output == "" {`
`164`	`164`	`output = filepath.Join(extractPath, path.Base(header.Name))`
`165`	`165`	`}`
	`166`	`+ output = output + "-new"`
`166`	`167`	`glog.V(9).Infof("extracting to %q", output)`
`167`	`168`	`outfile, err := os.Create(output)`
`168`	`169`	`if err != nil {`
`@@ -176,6 +177,7 @@ func ExtractTarGzipArchive(archiveFile, extractPath string, service *types.Servi`
`176`	`177`	`}`
`177`	`178`	`outfile.Chmod(fs.FileMode(header.Mode))`
`178`	`179`	`outfile.Close()`
	`180`	`+ os.Rename(output, filepath.Join(extractPath, path.Base(header.Name)))`
`179`	`181`	`}`
`180`	`182`	`}`
`181`	`183`	`return nil`