Remove change collection for ChangeTracked (#1450)

* Remove ChangeTracked collect(.byTime(...))

* Send `objectWillChange` on `MainActor`

* Update CHANGELOG.md

* Add PR link

---------

Signed-off-by: Brian Cardarella <[email protected]>
Co-authored-by: Brian Cardarella <[email protected]>

Author: carson-katri

CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## Changed
 
 ## Fixed
+- Updates to change-tracked properties no longer occur on the next RunLoop, fixing modal dismissal on macOS (#1450)
 - `+` characters are properly encoded as `%2B` in form events (#1449)
 
 ## [0.3.0] 2024-08-21

Sources/LiveViewNative/Coordinators/LiveViewCoordinator.swift

@@ -293,7 +293,6 @@ public class LiveViewCoordinator<R: RootRegistry>: ObservableObject {
         channel.on("phx_close") { [weak self, weak channel] message in
             Task { @MainActor in
                 guard channel === self?.channel else { return }
-                print("State changed to: phx_close")
                 self?.internalState = .disconnected
             }
         }

Sources/LiveViewNative/Property Wrappers/ChangeTracked.swift

@@ -102,10 +102,10 @@ extension ChangeTracked where Value: AttributeDecodable {
                 self.previousValue = value
             }
             cancellable = localValueChanged
-                .collect(.byTime(RunLoop.current, RunLoop.current.minimumTolerance))
-                .compactMap(\.last)
                 .sink(receiveValue: { [weak self] localValue in
-                    self?.objectWillChange.send()
+                    Task { @MainActor [weak self] in
+                        self?.objectWillChange.send()
+                    }
                     self?.value = localValue
                     Task { [weak self] in
                         guard let self,
@@ -118,12 +118,13 @@ extension ChangeTracked where Value: AttributeDecodable {
             // set current value to previousValue and trigger update to sync with attribute value
             // (may be delayed from localValueChanged due to debounce/throttle)
             didSendCancellable = changeTracked.event.owner.handler.didSendSubject
-                .collect(.byTime(RunLoop.current, RunLoop.current.minimumTolerance))
                 .sink { [weak self] _ in
                     guard let self
                     else { return }
                     self.previousValue = self.value
-                    self.objectWillChange.send()
+                    Task { @MainActor [weak self] in
+                        self?.objectWillChange.send()
+                    }
                 }
         }
     }
@@ -170,10 +171,10 @@ extension ChangeTracked where Value: FormValue {
             }
 
             cancellable = localValueChanged
-                .collect(.byTime(RunLoop.current, RunLoop.current.minimumTolerance))
-                .compactMap(\.last)
                 .sink(receiveValue: { [weak self] localValue in
-                    self?.objectWillChange.send()
+                    Task { @MainActor [weak self] in
+                        self?.objectWillChange.send()
+                    }
                     self?.value = localValue
                     if changeTracked._event.debounceAttribute != .blur { // the input element should call `pushChangeEvent` when it loses focus.
                         Task { [weak self] in
@@ -188,12 +189,13 @@ extension ChangeTracked where Value: FormValue {
             // set current value to previousValue and trigger update to sync with attribute value
             // (may be delayed from localValueChanged due to debounce/throttle)
             didSendCancellable = changeTracked.event.owner.handler.didSendSubject
-                .collect(.byTime(RunLoop.current, RunLoop.current.minimumTolerance))
-                .sink { [weak self] _ in
+                .sink { @MainActor [weak self] _ in
                     guard let self
                     else { return }
                     self.previousValue = self.value
-                    self.objectWillChange.send()
+                    Task { @MainActor [weak self] in
+                        self?.objectWillChange.send()
+                    }
                 }
         }