fix: add tests for smart quotes helper functions

Author: eileenoo

spec/smartQuotes.spec.js

@@ -0,0 +1,82 @@
+import {expect} from 'chai'
+import {isDoubleQuote, isSingleQuote, isWhitespace, isSeparatorOrWhitespace, isApostrophe} from '../src/smartQuotes'
+
+const allSingleQuotes = ['‘', '’', '‹', '›', '‚', '‘', '›', '‹', `'`, `‘`]
+const allDoubleQuotes = ['«', '»', '»', '«', '"', '"', '“', '”', '”', '”', '“', '“', '„', '“']
+const charValues = ['', '*', '<', 'b', 'ab']
+const nonStringValues = [undefined, null, true, 123, NaN]
+const whitespaceChars = [' ', '\t', '\n', '\r', '\v', '\f']
+const separatorValues = ['>', '-', '–—']
+
+describe('Smart Quotes Helper Functions', () => {
+  describe('isDoubleQuote', () => {
+    it('Should return false for non double quote values', () => {
+      [...charValues, ...separatorValues, ...nonStringValues, ...allSingleQuotes].forEach(value => {
+        expect(isDoubleQuote(value)).to.equal(false, `Failed for value: ${value}`)
+      })
+    })
+
+    it('Should return true for double quote values', () => {
+      allDoubleQuotes.forEach(value => {
+        expect(isDoubleQuote(value)).to.equal(true, `Failed for value: ${value}`)
+      })
+    })
+  })
+
+  describe('isSingleQuote', () => {
+    it('Should return false for non single quote values', () => {
+      [...charValues, ...separatorValues, ...nonStringValues, ...allDoubleQuotes].forEach(value => {
+        expect(isSingleQuote(value)).to.equal(false, `Failed for value: ${value}`)
+      })
+    })
+
+    it('Should return true for single quote values', () => {
+      allSingleQuotes.forEach(value => {
+        expect(isSingleQuote(value)).to.equal(true, `Failed for value: ${value}`)
+      })
+    })
+  })
+
+  describe('isWhiteSpace', () => {
+    it('should return false for non whitespace characters', () => {
+      [...charValues, ...nonStringValues].forEach(value => {
+        expect(isWhitespace(value)).to.equal(false, `Failed for: ${value}`)
+      })
+    })
+
+    it('should return true for  whitespace characters', () => {
+      [...whitespaceChars ].forEach(value => {
+        expect(isWhitespace(value)).to.equal(true, `Failed for: ${value}`)
+      })
+    })
+  })
+
+  describe('isSeparatorOrWhitespace', () => {
+    it('should return false for non whitespace / separator characters', () => {
+      [...charValues, ...nonStringValues ].forEach(value => {
+        expect(isSeparatorOrWhitespace(value)).to.equal(false, `Failed for: ${value}`)
+      })
+    })
+
+    it('should return true for  whitespace/ separator characters', () => {
+      [...whitespaceChars, ...separatorValues].forEach(value => {
+        expect(isSeparatorOrWhitespace(value)).to.equal(true, `Failed for: ${value}`)
+      })
+    })
+  })
+
+  describe('isApostrophe', () => {
+    it('should return false for non apostrophe characters', () => {
+      [...charValues, ...nonStringValues, ...allDoubleQuotes, `'f`, '’j', '‘', '‹', '›', '‚', '‘', '›', '‹', `‘`].forEach(value => {
+        expect(isApostrophe(value)).to.equal(false, `Failed for: ${value}`)
+      })
+    })
+
+    it('should return true for apostrophe characters', () => {
+      [`'`, '’'].forEach(value => {
+        expect(isApostrophe(value)).to.equal(true, `Failed for: ${value}`)
+      })
+    })
+  })
+})
+

src/smartQuotes.js

@@ -4,12 +4,12 @@ export const shouldApplySmartQuotes = (config, target) => {
   const {smartQuotes, quotes, singleQuotes} = config
   return !!smartQuotes && isValidQuotePairConfig(quotes) && isValidQuotePairConfig(singleQuotes) && target.isContentEditable
 }
-
-const isDoubleQuote = (char) => /^[«»"“”„]$/.test(char)
-const isSingleQuote = (char) => /^[‘’‹›‚']$/.test(char)
-const isApostrophe = (char) => /^[’']$/.test(char)
-const isWhitespace = (char) => /^\s$/.test(char)
-const isSeparatorOrWhitespace = (char) => /\s|[>\-–—]/.test(char)
+// TODO: isDoubleQuote, isSingleQuote, isApostrophe, isWhitespace accept more than one char
+export const isDoubleQuote = (char) => /^[«»"“”„]$/.test(char)
+export const isSingleQuote = (char) => /^[‘’‹›‚']$/.test(char)
+export const isApostrophe = (char) => /^[’']$/.test(char)
+export const isWhitespace = (char) => /^\s$/.test(char)
+export const isSeparatorOrWhitespace = (char) => /\s|[>\-–—]/.test(char)
 
 const shouldBeOpeningQuote = (text, indexCharBefore) => indexCharBefore < 0 || isSeparatorOrWhitespace(text[indexCharBefore])
 const shouldBeClosingQuote = (text, indexCharBefore) => !!text[indexCharBefore] && !isSeparatorOrWhitespace(text[indexCharBefore])