fix(build): fix log file upload (mainsail-crew#297)

* fix(build): change step order

Signed-off-by: Stephan Wendel <me@stephanwe.de>

* chore(build): fix syntax

* Set order to previous locations

Signed-off-by: Stephan Wendel <me@stephanwe.de>

* test: add failing build for test

Will be removed after testing, due revert

Signed-off-by: Stephan Wendel <me@stephanwe.de>

* fix: fix log file naming

Signed-off-by: Stephan Wendel <me@stephanwe.de>

* Revert "test: add failing build for test"

This reverts commit 2829fe2.

---------

Signed-off-by: Stephan Wendel <me@stephanwe.de>

Author: KwadFan

.github/workflows/BuildImages.yml

@@ -67,7 +67,7 @@ jobs:
 
       - name: Rename image file
         id: move-image
-        if: always()
+        if: ${{ success() }}
         shell: bash
         run: |
           source repository/src/config
@@ -79,10 +79,10 @@ jobs:
           echo "image=${IMAGE}" >> $GITHUB_OUTPUT
 
       - name: Upload failed Logfile
-        if: failure()
+        if: ${{ failure() && steps.build.conclusion == 'failure' }}
         uses: actions/upload-artifact@v4
         with:
-          name: failed-${{ steps.move-image.outputs.image }}.log
+          name: failed-${{ steps.build.outputs.type }}-${{ steps.build.outputs.sbc }}.log
           path: repository/src/build.log
 
       - name: Compressing Image