Skip to content

Commit 5a9b9f2

Browse files
authored
fix: update recording workflow action SHAs to include skip-commit support (#5199)
## Summary Updates the pinned action SHAs in the recording workflow to point to the current main branch that includes the merged changes from #5123. ## Problem The workflow was failing with: ``` remote: Permission to llamastack/llama-stack.git denied to github-actions[bot]. fatal: unable to access 'https://github.com/llamastack/llama-stack/': The requested URL returned error: 403 ``` This happened because the pinned SHAs (`ce063acf`) were from before #5123 merged, so they didn't support the `skip-commit: true` parameter. The old action tried to push recordings directly (which fails with read-only permissions). ## Solution Updated both action SHAs to `4a4f48ff` (current main) which: - Respects `skip-commit: true` parameter - Uploads recordings as artifacts - Allows the companion workflow to handle commits with proper write permissions ## Test plan - [x] Verified the workflow now uses the correct action version that supports skip-commit - [ ] Manual workflow_dispatch trigger should now work without 403 errors Fixes the workflow failures seen in https://github.com/llamastack/llama-stack/actions/runs/23263329503 Signed-off-by: Charlie Doern <cdoern@redhat.com>
1 parent 4a4f48f commit 5a9b9f2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/record-integration-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ jobs:
190190
# a trusted commit, not from PR checkout. This is critical for security.
191191
- name: Setup test environment
192192
if: steps.should_run.outputs.run == 'true'
193-
uses: llamastack/llama-stack/.github/actions/setup-test-environment@ce063acfe127393537cb0a5deb29cd20063c76af
193+
uses: llamastack/llama-stack/.github/actions/setup-test-environment@4a4f48ffda71163aba27360a8cb172d4fddb398c
194194
with:
195195
python-version: "3.12"
196196
client-version: "latest"
@@ -200,7 +200,7 @@ jobs:
200200

201201
- name: Run and record tests
202202
if: steps.should_run.outputs.run == 'true'
203-
uses: llamastack/llama-stack/.github/actions/run-and-record-tests@ce063acfe127393537cb0a5deb29cd20063c76af
203+
uses: llamastack/llama-stack/.github/actions/run-and-record-tests@4a4f48ffda71163aba27360a8cb172d4fddb398c
204204
env:
205205
OPENAI_API_KEY: ${{ matrix.provider.setup == 'gpt' && secrets.OPENAI_API_KEY || '' }}
206206
AZURE_API_KEY: ${{ matrix.provider.setup == 'azure' && secrets.AZURE_API_KEY || '' }}

0 commit comments

Comments
 (0)