-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Labels
enhancementNew feature or requestNew feature or request
Description
🚀 Describe the new functionality needed
Context: As per ashwinb's comment about adding Bedrock integration tests to CI.
could we add them to CI? we could introduce a new job for this which does provider specific integration tests -- and you could include which credentials are needed and how are they to be obtained if someone does need to re-record things. Curious to hear what others think.
Allow to add more recordings or update existing.
💡 Why is this needed? What if we don't build it?
Current Problem
The Bedrock provider integration test recordings (added in PR #3748) are being flagged as "unused" by scripts/cleanup_recordings.py because:
- The cleanup script only recognizes tests that run in the CI matrix (
tests/integration/ci_matrix.json) - Current CI matrix only includes:
ollama,ollama-vision,gpt, andvllm - Bedrock recordings exist but Bedrock tests don't run in CI → recordings marked for deletion
Proposed Solution
Implement a provider-specific CI workflow for Bedrock that:
- Runs in replay mode on PRs (no credentials needed using committed recordings)
Other thoughts
Please provide feedback or comments or any questions you may have here.
ktdreyer
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request