Relax the checks for "stack-list-*" MI cmd (#46)

Relax the checks for "stack-list-*" MI cmd

The "stack-list-*" MI commands were checking whether the
thread was stopped.  However, for state of some threads
would not be stopped even when they clearly are. This was
not an issue for non-MI commands since they don't check
that the thread is stopped. This change relaxes the checks
performed by the MI commands to match the ones by the
non-MI commands.

Author: WardenGnaw

src/MICmdCmdStack.cpp

@@ -33,6 +33,32 @@
 
 #include <algorithm>
 
+//++
+// Details: The check for the non-MI command "frame variable" validates that the
+//          process is paused and the frame exists.
+// Type:    Method.
+// Args:    processState     - the current process state.
+//          threadInvalid    - (R) Caller's m_bThreadInvalid member.
+// Return:  MIstatus::success - Function succeeded.
+//          MIstatus::failure - Function failed.
+// Throws:  None.
+//--
+bool EnsureProcessIsPaused(lldb::StateType processState, bool &threadInvalid) {
+  switch (processState) {
+  case lldb::eStateInvalid:
+  case lldb::eStateCrashed:
+    threadInvalid = true;
+    return MIstatus::failure;
+  case lldb::eStateSuspended:
+  case lldb::eStateStopped:
+    break;
+  default:
+    threadInvalid = true;
+  }
+
+  return MIstatus::success;
+}
+
 //++
 // Details: CMICmdCmdStackInfoDepth constructor.
 // Type:    Method.
@@ -519,20 +545,18 @@ bool CMICmdCmdStackListArguments::Execute() {
   CMICmnLLDBDebugSessionInfo &rSessionInfo(
       CMICmnLLDBDebugSessionInfo::Instance());
   lldb::SBProcess sbProcess = rSessionInfo.GetProcess();
+
+  if (!EnsureProcessIsPaused(sbProcess.GetState(), m_bThreadInvalid)) {
+    return MIstatus::failure;
+  }
+
   lldb::SBThread thread = (nThreadId != UINT64_MAX)
                               ? sbProcess.GetThreadByIndexID(nThreadId)
                               : sbProcess.GetSelectedThread();
-  m_bThreadInvalid = !thread.IsValid();
+  m_bThreadInvalid |= !thread.IsValid();
   if (m_bThreadInvalid)
     return MIstatus::success;
 
-  const lldb::StopReason eStopReason = thread.GetStopReason();
-  if ((eStopReason == lldb::eStopReasonNone) ||
-      (eStopReason == lldb::eStopReasonInvalid)) {
-    m_bThreadInvalid = true;
-    return MIstatus::success;
-  }
-
   const MIuint nFrames = thread.GetNumFrames();
   if (nFrameLow >= nFrames) {
     // The low-frame is larger than the actual number of frames
@@ -857,20 +881,18 @@ bool CMICmdCmdStackListVariables::Execute() {
   CMICmnLLDBDebugSessionInfo &rSessionInfo(
       CMICmnLLDBDebugSessionInfo::Instance());
   lldb::SBProcess sbProcess = rSessionInfo.GetProcess();
+
+  if (!EnsureProcessIsPaused(sbProcess.GetState(), m_bThreadInvalid)) {
+    return MIstatus::failure;
+  }
+
   lldb::SBThread thread = (nThreadId != UINT64_MAX)
                               ? sbProcess.GetThreadByIndexID(nThreadId)
                               : sbProcess.GetSelectedThread();
-  m_bThreadInvalid = !thread.IsValid();
+  m_bThreadInvalid |= !thread.IsValid();
   if (m_bThreadInvalid)
     return MIstatus::success;
 
-  const lldb::StopReason eStopReason = thread.GetStopReason();
-  if ((eStopReason == lldb::eStopReasonNone) ||
-      (eStopReason == lldb::eStopReasonInvalid)) {
-    m_bThreadInvalid = true;
-    return MIstatus::success;
-  }
-
   lldb::SBFrame frame = (nFrame != UINT64_MAX) ? thread.GetFrameAtIndex(nFrame)
                                                : thread.GetSelectedFrame();