Skip to content

Commit 7e0a84d

Browse files
authored
Cleanup End to End test framework (#625)
* Removed duplicated line of code Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Images alreday pulled if needed via image-pull Makefile target Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> --------- Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
1 parent cdd8760 commit 7e0a84d

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

test/e2e/e2e_suite_test.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,6 @@ func setupK8sCluster() {
171171
kindLoadImage(vllmSimImage)
172172
kindLoadImage(eppImage)
173173
kindLoadImage(sideCarImage)
174-
kindLoadImage(vllmSimImage)
175174
}
176175

177176
func kindLoadImage(image string) {
@@ -183,15 +182,6 @@ func kindLoadImage(image string) {
183182
_, err := exec.LookPath(containerRuntime)
184183
gomega.Expect(err).ShouldNot(gomega.HaveOccurred(), "Could not find %s in PATH", containerRuntime)
185184

186-
// Pull the image first to ensure it's available locally
187-
ginkgo.By(fmt.Sprintf("Pulling image %s if not available locally", image))
188-
pullCommand := exec.Command(containerRuntime, "pull", image)
189-
pullSession, pullErr := gexec.Start(pullCommand, ginkgo.GinkgoWriter, ginkgo.GinkgoWriter)
190-
if pullErr == nil {
191-
// Wait for pull to complete, but don't fail if image already exists or can't be pulled
192-
gomega.Eventually(pullSession).WithTimeout(600 * time.Second).Should(gexec.Exit())
193-
}
194-
195185
saveArgs := []string{"save", "--output", target}
196186
if containerRuntime == "docker" {
197187
// The platform flag is required for docker save to work but it is an unsupported flag for podman

0 commit comments

Comments
 (0)