Skip to content

Commit b9c56d3

Browse files
authored
minor tweaks to Makefile (#318)
Signed-off-by: Nir Rozenbaum <[email protected]>
1 parent dc05adf commit b9c56d3

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

Makefile

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ TOKENIZER_LIB = lib/libtokenizers.a
4646
TOKENIZER_VERSION := $(shell grep '^ARG RELEASE_VERSION=' Dockerfile | cut -d'=' -f2)
4747

4848
.PHONY: download-tokenizer
49-
download-tokenizer: $(TOKENIZER_LIB)
49+
download-tokenizer: $(TOKENIZER_LIB) ## Download HuggingFace tokenizer
5050
$(TOKENIZER_LIB):
5151
## Download the HuggingFace tokenizer bindings.
5252
@echo "Downloading HuggingFace tokenizer bindings for version $(TOKENIZER_VERSION)..."
@@ -57,7 +57,7 @@ $(TOKENIZER_LIB):
5757
##@ Development
5858

5959
.PHONY: clean
60-
clean:
60+
clean: ## Clean HuggingFace tokenizer from file system
6161
go clean -testcache -cache
6262
rm -f $(TOKENIZER_LIB)
6363
rmdir lib
@@ -68,23 +68,23 @@ format: ## Format Go source files
6868
@gofmt -l -w $(SRC)
6969

7070
.PHONY: test
71-
test: test-unit test-e2e
71+
test: test-unit test-e2e ## Run unit tests and e2e tests
7272

7373
.PHONY: test-unit
74-
test-unit: download-tokenizer download-zmq
74+
test-unit: download-tokenizer download-zmq ## Run unit tests
7575
@printf "\033[33;1m==== Running Unit Tests ====\033[0m\n"
7676
go test -ldflags="$(LDFLAGS)" -v $$(echo $$(go list ./... | grep -v /test/))
7777

78-
.PHONY: test-e2e
79-
test-e2e: image-build
80-
@printf "\033[33;1m==== Running End to End Tests ====\033[0m\n"
81-
./test/scripts/run_e2e.sh
82-
8378
.PHONY: test-integration
84-
test-integration: download-tokenizer download-zmq
79+
test-integration: download-tokenizer download-zmq ## Run integration tests
8580
@printf "\033[33;1m==== Running Integration Tests ====\033[0m\n"
8681
go test -ldflags="$(LDFLAGS)" -v -tags=integration_tests ./test/integration/
8782

83+
.PHONY: test-e2e
84+
test-e2e: image-build ## Run end-to-end tests against a new kind cluster
85+
@printf "\033[33;1m==== Running End to End Tests ====\033[0m\n"
86+
./test/scripts/run_e2e.sh
87+
8888
.PHONY: post-deploy-test
8989
post-deploy-test: ## Run post deployment tests
9090
echo Success!

0 commit comments

Comments
 (0)