tracing: remove extra success result

sallyom · sallyom · commit f7bcc9dd4bf9 · 2026-01-20T19:59:42.000-05:00
Signed-off-by: sallyom &lt;somalley@redhat.com&gt;
diff --git a/pkg/plugins/scorer/precise_prefix_cache.go b/pkg/plugins/scorer/precise_prefix_cache.go
@@ -219,7 +219,6 @@ func (s *PrecisePrefixCacheScorer) Score(ctx context.Context, cycleState *types.
 		)
 	}
 
-	span.SetAttributes(attribute.String("llm_d.scorer.result", "success"))
 	return normalizedScores
 }
 
diff --git a/pkg/sidecar/proxy/chat_completions.go b/pkg/sidecar/proxy/chat_completions.go
@@ -56,6 +56,7 @@ func (s *Server) chatCompletionsHandler(w http.ResponseWriter, r *http.Request)
 
 	span.SetAttributes(
 		attribute.String("llm_d.pd_proxy.connector", s.config.Connector),
+		attribute.String("llm_d.pd_proxy.request_path", r.URL.Path),
 	)
 
 	var prefillHostPorts []string

Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,6 @@ func (s PrecisePrefixCacheScorer) Score(ctx context.Context, cycleState types.`
`219`	`219`	`)`
`220`	`220`	`}`
`221`	`221`
`222`		`- span.SetAttributes(attribute.String("llm_d.scorer.result", "success"))`
`223`	`222`	`return normalizedScores`
`224`	`223`	`}`
`225`	`224`
Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@ func (s Server) chatCompletionsHandler(w http.ResponseWriter, r http.Request)`
`56`	`56`
`57`	`57`	`span.SetAttributes(`
`58`	`58`	`attribute.String("llm_d.pd_proxy.connector", s.config.Connector),`
	`59`	`+ attribute.String("llm_d.pd_proxy.request_path", r.URL.Path),`
`59`	`60`	`)`
`60`	`61`
`61`	`62`	`var prefillHostPorts []string`