Skip to content

Commit 0e58ef3

Browse files
committed
fix custom dataset test case
Signed-off-by: Qifan Deng <[email protected]>
1 parent 6d29256 commit 0e58ef3

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

pkg/dataset/custom_dataset.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import (
2525
"errors"
2626
"fmt"
2727
"io"
28-
"math/rand"
2928
"net/http"
3029
"os"
3130
"os/signal"
@@ -385,6 +384,6 @@ func (d *CustomDataset) GenerateTokens(req openaiserverapi.CompletionRequest, nT
385384
return GenPresetRandomTokens(nTokens), nil
386385
}
387386
d.hasWarned = false
388-
randIndex := rand.Intn(len(tokensList))
387+
randIndex := common.RandomInt(0, len(tokensList)-1)
389388
return tokensList[randIndex], nil
390389
}

pkg/dataset/custom_dataset_test.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package dataset
1919
import (
2020
"encoding/json"
2121
"os"
22+
"time"
2223

2324
"github.com/go-logr/logr"
2425
"github.com/llm-d/llm-d-inference-sim/pkg/common"
@@ -33,7 +34,7 @@ const (
3334
testPrompt = "Hello world!"
3435
)
3536

36-
var _ = Describe("CustomDataset", func() {
37+
var _ = Describe("CustomDataset", Ordered, func() {
3738
var (
3839
dataset *CustomDataset
3940
file_folder string
@@ -46,6 +47,10 @@ var _ = Describe("CustomDataset", func() {
4647
pathToInvalidTypeDB string
4748
)
4849

50+
BeforeAll(func() {
51+
common.InitRandom(time.Now().UnixNano())
52+
})
53+
4954
BeforeEach(func() {
5055
dataset = &CustomDataset{
5156
BaseDataset: BaseDataset{

pkg/dataset/dataset_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ var _ = Describe("Dataset", Ordered, func() {
3636
BeforeAll(func() {
3737
common.InitRandom(time.Now().UnixNano())
3838
})
39+
3940
BeforeEach(func() {
4041
dataset = &BaseDataset{
4142
Logger: logr.Discard(),

0 commit comments

Comments
 (0)