Skip to content

Commit 1b56969

Browse files
committed
Move dataset init to startSim
Signed-off-by: Qifan Deng <[email protected]>
1 parent 76e9d86 commit 1b56969

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

pkg/llm-d-inference-sim/simulator.go

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -155,19 +155,6 @@ func (s *VllmSimulator) Start(ctx context.Context) error {
155155
return err
156156
}
157157

158-
if s.config.Dataset.Path == "" && s.config.Dataset.Url == "" && s.config.Dataset.SavePath == "" {
159-
s.dataset = nil
160-
} else {
161-
dataset := &Dataset{
162-
logger: s.logger,
163-
}
164-
err = dataset.Init(s.config.Dataset.Path, s.config.Dataset.Url, s.config.Dataset.SavePath)
165-
if err != nil {
166-
return err
167-
}
168-
s.dataset = dataset
169-
}
170-
171158
// For Data Parallel, start data-parallel-size - 1 additional simulators
172159
g, ctx := errgroup.WithContext(ctx)
173160
if s.config.DPSize > 1 {
@@ -229,6 +216,20 @@ func (s *VllmSimulator) startSim(ctx context.Context) error {
229216
go s.kvcacheHelper.Run(ctx)
230217
}
231218

219+
if s.config.Dataset.Path == "" && s.config.Dataset.Url == "" && s.config.Dataset.SavePath == "" {
220+
s.dataset = nil
221+
s.logger.Info("No dataset provided, will generate random responses")
222+
} else {
223+
dataset := &Dataset{
224+
logger: s.logger,
225+
}
226+
err = dataset.Init(s.config.Dataset.Path, s.config.Dataset.Url, s.config.Dataset.SavePath)
227+
if err != nil {
228+
return err
229+
}
230+
s.dataset = dataset
231+
}
232+
232233
// run request processing workers
233234
for i := 1; i <= s.config.MaxNumSeqs; i++ {
234235
go s.reqProcessingWorker(ctx, i)

0 commit comments

Comments
 (0)