Skip to content

Commit 3404143

Browse files
committed
Add invalid test cases for args prefill-overhead and kv-cache-transfer-overhead
Signed-off-by: Qifan Deng <[email protected]>
1 parent 58544fe commit 3404143

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

pkg/common/config_test.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -388,6 +388,11 @@ var _ = Describe("Simulator configuration", func() {
388388
name: "invalid (negative) zmq-max-connect-attempts for config file",
389389
args: []string{"cmd", "--config", "../../manifests/invalid-config.yaml"},
390390
},
391+
{
392+
name: "invalid (negative) prefill-overhead",
393+
args: []string{"cmd", "--prefill-overhead", "-1",
394+
"--config", "../../manifests/config.yaml"},
395+
},
391396
{
392397
name: "<prefill-overhead> must be set when <prefill-complexity> is set",
393398
args: []string{"cmd", "--prefill-complexity", "n^2", "--config", "../../manifests/config.yaml"},
@@ -396,6 +401,11 @@ var _ = Describe("Simulator configuration", func() {
396401
name: "<prefill-complexity> should not be 'xxx'",
397402
args: []string{"cmd", "--prefill-complexity", "xxx", "--config", "../../manifests/config.yaml"},
398403
},
404+
{
405+
name: "invalid (negative) kv-cache-transfer-overhead",
406+
args: []string{"cmd", "--kv-cache-transfer-overhead", "-1",
407+
"--config", "../../manifests/config.yaml"},
408+
},
399409
{
400410
name: "<kv-cache-transfer-overhead> must be set when <kv-cache-transfer-complexity> is set",
401411
args: []string{"cmd", "--kv-cache-transfer-complexity", "linear", "--config", "../../manifests/config.yaml"},

0 commit comments

Comments
 (0)