Skip to content

Commit 7bcee36

Browse files
authored
use newer version of kvcache-manager, update code accordingly (#133)
Signed-off-by: Maya Barnea <[email protected]>
1 parent c1ba592 commit 7bcee36

File tree

4 files changed

+19
-27
lines changed

4 files changed

+19
-27
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ require (
88
github.com/buaazp/fasthttprouter v0.1.1
99
github.com/go-logr/logr v1.4.2
1010
github.com/google/uuid v1.6.0
11-
github.com/llm-d/llm-d-kv-cache-manager v0.2.2-0.20250810103202-0adf0940f60a
11+
github.com/llm-d/llm-d-kv-cache-manager v0.2.2-0.20250814115305-d5a8ca882318
1212
github.com/onsi/ginkgo/v2 v2.23.4
1313
github.com/onsi/gomega v1.37.0
1414
github.com/openai/openai-go v0.1.0-beta.10

go.sum

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
github.com/alicebob/miniredis/v2 v2.35.0 h1:QwLphYqCEAo1eu1TqPRN2jgVMPBweeQcR21jeqDCONI=
2+
github.com/alicebob/miniredis/v2 v2.35.0/go.mod h1:TcL7YfarKPGDAthEtl5NBeHZfeUQj6OXMm/+iu5cLMM=
13
github.com/andybalholm/brotli v1.1.1 h1:PR2pgnyFznKEugtsUo0xLdDop5SKXd5Qf5ysW+7XdTA=
24
github.com/andybalholm/brotli v1.1.1/go.mod h1:05ib4cKhjx3OQYUY22hTVd34Bc8upXjOLL2rKwwZBoA=
35
github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
@@ -11,8 +13,6 @@ github.com/buaazp/fasthttprouter v0.1.1/go.mod h1:h/Ap5oRVLeItGKTVBb+heQPks+HdIU
1113
github.com/cespare/xxhash/v2 v2.3.0 h1:UL815xU9SqsFlibzuggzjXhog7bL6oX9BbNZnL2UFvs=
1214
github.com/cespare/xxhash/v2 v2.3.0/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs=
1315
github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
14-
github.com/daulet/tokenizers v1.20.2 h1:tlq/vIOiBTKDPets3596aFvmJYLn3XI6LFKq4q9LKhQ=
15-
github.com/daulet/tokenizers v1.20.2/go.mod h1:tGnMdZthXdcWY6DGD07IygpwJqiPvG85FQUnhs/wSCs=
1616
github.com/daulet/tokenizers v1.22.1 h1:3wzAFIxfgRuqGKka8xdkeTbctDmmqOOs12GofqdorpM=
1717
github.com/daulet/tokenizers v1.22.1/go.mod h1:tGnMdZthXdcWY6DGD07IygpwJqiPvG85FQUnhs/wSCs=
1818
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
@@ -68,10 +68,8 @@ github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
6868
github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
6969
github.com/kylelemons/godebug v1.1.0 h1:RPNrshWIDI6G2gRW9EHilWtl7Z6Sb1BR0xunSBf0SNc=
7070
github.com/kylelemons/godebug v1.1.0/go.mod h1:9/0rRGxNHcop5bhtWyNeEfOS8JIWk580+fNqagV/RAw=
71-
github.com/llm-d/llm-d-kv-cache-manager v0.2.0 h1:7MXFPjy3P8nZ7HbB1LWhhVLHvNTLbZglkD/ZcT7UU1k=
72-
github.com/llm-d/llm-d-kv-cache-manager v0.2.0/go.mod h1:ZTqwsnIVC6R5YuTUrYofPIUnCeZ9RvXn1UQAdxLYl1Y=
73-
github.com/llm-d/llm-d-kv-cache-manager v0.2.2-0.20250810103202-0adf0940f60a h1:PXR37HLgYYfolzWQA2uQOEiJlj3IV9YSvgaEFqCRSa8=
74-
github.com/llm-d/llm-d-kv-cache-manager v0.2.2-0.20250810103202-0adf0940f60a/go.mod h1:g2UlYKNJ4S860SAQ/QoRnytAFfnp8f1luW4IuZSMwCE=
71+
github.com/llm-d/llm-d-kv-cache-manager v0.2.2-0.20250814115305-d5a8ca882318 h1:4V1tDOzD0EzatsdOjJnEt7+dJDQPTozfUU4g29dCrTY=
72+
github.com/llm-d/llm-d-kv-cache-manager v0.2.2-0.20250814115305-d5a8ca882318/go.mod h1:g2UlYKNJ4S860SAQ/QoRnytAFfnp8f1luW4IuZSMwCE=
7573
github.com/mailru/easyjson v0.7.7 h1:UGYAvKxe3sBsEDzO8ZeWOSlIQfWFlxbzLZe7hwFURr0=
7674
github.com/mailru/easyjson v0.7.7/go.mod h1:xzfreul335JAWq5oZzymOObrkdz5UnU4kGfJJLY9Nlc=
7775
github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421/go.mod h1:6dJC0mAP4ikYIbvyc7fijjWJddQyLn8Ig3JB5CqoB9Q=
@@ -147,6 +145,8 @@ github.com/xyproto/randomstring v1.0.5 h1:YtlWPoRdgMu3NZtP45drfy1GKoojuR7hmRcnhZ
147145
github.com/xyproto/randomstring v1.0.5/go.mod h1:rgmS5DeNXLivK7YprL0pY+lTuhNQW3iGxZ18UQApw/E=
148146
github.com/yuin/goldmark v1.1.27/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
149147
github.com/yuin/goldmark v1.2.1/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
148+
github.com/yuin/gopher-lua v1.1.1 h1:kYKnWBjvbNP4XLT3+bPEwAXJx262OhaHDWDVOPjL46M=
149+
github.com/yuin/gopher-lua v1.1.1/go.mod h1:GBR0iDaNXjAgGg9zfCvksxSRnQx76gclCIb7kdAd1Pw=
150150
go.uber.org/automaxprocs v1.6.0 h1:O3y2/QNTOdbF+e/dpXNNW7Rx2hZ4sTIPyybbxyNqTUs=
151151
go.uber.org/automaxprocs v1.6.0/go.mod h1:ifeIMSnPZuznNm6jmdzmU3/bfk01Fe2fotchwEFJ8r8=
152152
go.uber.org/goleak v1.3.0 h1:2K3zAYmnTNqV73imy9J1T3WC+gmCePx2hEGkimedGto=

pkg/kv-cache/kv_cache_sender.go

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ limitations under the License.
1616
package kvcache
1717

1818
import (
19-
"bytes"
2019
"context"
2120
"fmt"
2221
"time"
@@ -90,32 +89,22 @@ func (s *KVEventSender) Run(ctx context.Context) error {
9089
}
9190

9291
// Encode eventData's hash value to msgpack.RawMessage
92+
var payload []byte
9393
var err error
94-
var payload bytes.Buffer
95-
enc := msgpack.NewEncoder(&payload)
96-
enc.UseArrayEncodedStructs(true)
9794

9895
switch eventData.action {
9996
case eventActionStore:
100-
bs := &kvevents.BlockStoredEvent{
101-
TypeField: BlockStored,
102-
BlockStored: &kvevents.BlockStored{BlockHashes: eventData.hashValues},
103-
}
104-
err = enc.Encode(bs)
97+
payload, err = msgpack.Marshal(kvevents.BlockStored{BlockHashes: eventData.hashValues}.ToTaggedUnion())
10598
case eventActionRemove:
106-
br := &kvevents.BlockRemovedEvent{
107-
TypeField: BlockRemoved,
108-
BlockRemoved: &kvevents.BlockRemoved{BlockHashes: eventData.hashValues},
109-
}
110-
err = enc.Encode(br)
99+
payload, err = msgpack.Marshal(kvevents.BlockRemoved{BlockHashes: eventData.hashValues}.ToTaggedUnion())
111100
default:
112101
return fmt.Errorf("invalid event action %d", eventData.action)
113102
}
114103
if err != nil {
115104
return fmt.Errorf("failed to marshal value: %w", err)
116105
}
117106

118-
s.batch = append(s.batch, payload.Bytes())
107+
s.batch = append(s.batch, payload)
119108

120109
// check if batch is big enough to be sent
121110
if len(s.batch) >= s.maxBatchSize {

pkg/kv-cache/kv_cache_test.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -496,22 +496,25 @@ func parseEvent(parts [][]byte, expectedTopic string, expectedSeq uint64) ([]uin
496496
Expect(err).NotTo(HaveOccurred())
497497
for _, rawEvent := range eventBatch.Events {
498498
var taggedUnion []msgpack.RawMessage
499-
err = msgpack.Unmarshal(rawEvent, &taggedUnion)
499+
err := msgpack.Unmarshal(rawEvent, &taggedUnion)
500500
Expect(err).NotTo(HaveOccurred())
501501
Expect(len(taggedUnion)).To(BeNumerically(">", 1))
502502

503+
payloadBytes, err := msgpack.Marshal(taggedUnion[1:])
504+
Expect(err).NotTo(HaveOccurred())
505+
503506
var tag string
504507
err = msgpack.Unmarshal(taggedUnion[0], &tag)
505508
Expect(err).NotTo(HaveOccurred())
506509

507510
switch tag {
508511
case BlockStored:
509-
var bs kvevents.BlockStoredEvent
510-
err = msgpack.Unmarshal(rawEvent, &bs)
512+
var bs kvevents.BlockStored
513+
err = msgpack.Unmarshal(payloadBytes, &bs)
511514
stored = append(stored, bs.BlockHashes...)
512515
case BlockRemoved:
513-
var br kvevents.BlockRemovedEvent
514-
err = msgpack.Unmarshal(rawEvent, &br)
516+
var br kvevents.BlockRemoved
517+
err = msgpack.Unmarshal(payloadBytes, &br)
515518
removed = append(removed, br.BlockHashes...)
516519

517520
default:

0 commit comments

Comments
 (0)