Skip to content

Commit 904e18d

Browse files
committed
Fix invalid config test of new ttft params
Signed-off-by: Qifan Deng <[email protected]>
1 parent 4ae89f2 commit 904e18d

File tree

1 file changed

+9
-20
lines changed

1 file changed

+9
-20
lines changed

pkg/common/config_test.go

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -407,35 +407,24 @@ var _ = Describe("Simulator configuration", func() {
407407
"--config", "../../manifests/config.yaml"},
408408
},
409409
{
410-
name: "invalid (negative) prefill-overhead-std-dev",
411-
args: []string{"cmd", "--prefill-overhead-std-dev", "-1",
410+
name: "invalid (negative) prefill-time-per-token",
411+
args: []string{"cmd", "--prefill-time-per-token", "-1",
412412
"--config", "../../manifests/config.yaml"},
413413
},
414414
{
415-
name: "<prefill-overhead> must be set when <prefill-complexity> is set",
416-
args: []string{"cmd", "--prefill-complexity", "n^2", "--config", "../../manifests/config.yaml"},
417-
},
418-
{
419-
name: "<prefill-complexity> should not be 'xxx'",
420-
args: []string{"cmd", "--prefill-complexity", "xxx", "--config", "../../manifests/config.yaml"},
421-
},
422-
{
423-
name: "invalid (negative) kv-cache-transfer-overhead",
424-
args: []string{"cmd", "--kv-cache-transfer-overhead", "-1",
415+
name: "invalid (negative) prefill-time-std-dev",
416+
args: []string{"cmd", "--prefill-time-std-dev", "-1",
425417
"--config", "../../manifests/config.yaml"},
426418
},
427419
{
428-
name: "invalid (negative) kv-cache-transfer-overhead-std-dev",
429-
args: []string{"cmd", "--kv-cache-transfer-overhead-std-dev", "-1",
420+
name: "invalid (negative) kv-cache-transfer-time-per-token",
421+
args: []string{"cmd", "--kv-cache-transfer-time-per-token", "-1",
430422
"--config", "../../manifests/config.yaml"},
431423
},
432424
{
433-
name: "<kv-cache-transfer-overhead> must be set when <kv-cache-transfer-complexity> is set",
434-
args: []string{"cmd", "--kv-cache-transfer-complexity", "linear", "--config", "../../manifests/config.yaml"},
435-
},
436-
{
437-
name: "<kv-cache-transfer-complexity> should not be 'xxx'",
438-
args: []string{"cmd", "--kv-cache-transfer-complexity", "xxx", "--config", "../../manifests/config.yaml"},
425+
name: "invalid (negative) kv-cache-transfer-time-std-dev",
426+
args: []string{"cmd", "--kv-cache-transfer-time-std-dev", "-1",
427+
"--config", "../../manifests/config.yaml"},
439428
},
440429
}
441430

0 commit comments

Comments
 (0)