Skip to content

Commit b6435bc

Browse files
committed
Add cli arg of dataset path and url, also update readme
Signed-off-by: Qifan Deng <[email protected]>
1 parent 53f199b commit b6435bc

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,10 @@ For more details see the <a href="https://docs.vllm.ai/en/stable/getting_started
149149
{"running-requests":10,"waiting-requests":30,"kv-cache-usage":0.4,"loras":[{"running":"lora4,lora2","waiting":"lora3","timestamp":1257894567},{"running":"lora4,lora3","waiting":"","timestamp":1257894569}]}
150150
---
151151
- `data-parallel-size`: number of ranks to run in Data Parallel deployment, from 1 to 8, default is 1. The ports will be assigned as follows: rank 0 will run on the configured `port`, rank 1 on `port`+1, etc.
152-
152+
---
153+
- `dataset-path`: local path to the sqlite db file for response generation from a dataset, optional, if not set, but `dataset-url` is set, the default path `<USER_HOME>/.llm-d/dataset.sqlite3` will be used. If neither dataset-path nor dataset-url are set, response is randomly generated. See [llm-d converted ShareGPT](https://huggingface.co/datasets/llm-d/inference-sim-datasets/tree/980e326f222e3e7390eef9df02a4f5e77d2a6da0/huggingface/ShareGPT_Vicuna_unfiltered) for more details on the expected format of the sqlite db file.
154+
- `dataset-url`: URL to download the sqlite db file for response generation from a dataset, optional, if set, the sqlite db file will be downloaded to the path specified by `dataset-path`. If the file already exists at that path, it will not be downloaded again. Example url: `https://huggingface.co/datasets/llm-d/inference-sim-datasets/resolve/980e326f222e3e7390eef9df02a4f5e77d2a6da0/huggingface/ShareGPT_Vicuna_unfiltered/conversations.sqlite3?download=true`
155+
---
153156
In addition, as we are using klog, the following parameters are available:
154157
- `add_dir_header`: if true, adds the file directory to the header of the log messages
155158
- `alsologtostderr`: log to standard error as well as files (no effect when -logtostderr=true)

pkg/common/config.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -556,6 +556,9 @@ func ParseCommandParamsAndLoadConfig() (*Configuration, error) {
556556
f.IntVar(&config.EventBatchSize, "event-batch-size", config.EventBatchSize, "Maximum number of kv-cache events to be sent together")
557557
f.IntVar(&config.DPSize, "data-parallel-size", config.DPSize, "Number of ranks to run")
558558

559+
f.StringVar(&config.Dataset.Path, "dataset-path", config.Dataset.Path, "Local path to the sqlite db file for response generation from a dataset")
560+
f.StringVar(&config.Dataset.Url, "dataset-url", config.Dataset.Url, "URL to download the sqlite db file for response generation from a dataset")
561+
559562
f.IntVar(&config.FailureInjectionRate, "failure-injection-rate", config.FailureInjectionRate, "Probability (0-100) of injecting failures")
560563
failureTypes := getParamValueFromArgs("failure-types")
561564
var dummyFailureTypes multiString

0 commit comments

Comments
 (0)