fix(make): properly resolves package manager for ZMQ installation (#204)

The recipe for identifying package manager (e.g. `$(command -v dnf)`)
has always been evaluated to empty thus skipping automated installation.

This PR fixes the issue and uses make target in the github action for
consistency.

Signed-off-by: Bartosz Majsak <[email protected]>

Author: bartoszmajsak

.github/workflows/ci-pr-checks.yaml

@@ -24,7 +24,7 @@ jobs:
       - name: Install libzmq dependencies (kvcache/kvevents)
         run: |
           sudo apt-get update
-          sudo apt-get install -y libzmq3-dev pkg-config
+          make download-zmq
 
       - name: Set PKG_CONFIG_PATH
         run: echo "PKG_CONFIG_PATH=/usr/lib/pkgconfig" >> $GITHUB_ENV

Makefile

@@ -241,29 +241,29 @@ install-hooks: ## Install git hooks
 
 .PHONY: download-zmq
 download-zmq: ## Install ZMQ dependencies based on OS/ARCH
-	@echo "Checking if ZMQ is already installed..."
+	@echo "⏳ Checking if ZMQ is already installed..."
 	@if pkg-config --exists libzmq; then \
 	  echo "✅ ZMQ is already installed."; \
 	else \
-	  echo "Installing ZMQ dependencies..."; \
+	  echo "⏳ Installing ZMQ dependencies..."; \
 	  if [ "$(TARGETOS)" = "linux" ]; then \
-	    if [ -x "$(command -v apt)" ]; then \
-	      apt update && apt install -y libzmq3-dev; \
-	    elif [ -x "$(command -v dnf)" ]; then \
-	      dnf install -y zeromq-devel; \
+	    if command -v apt >/dev/null 2>&1; then \
+	      sudo apt update && sudo apt install -y libzmq3-dev; \
+	    elif command -v dnf >/dev/null 2>&1; then \
+	      sudo dnf install -y zeromq-devel; \
 	    else \
-	      echo "Unsupported Linux package manager. Install libzmq manually."; \
+	      echo -e "⚠️ Unsupported Linux package manager. Follow installation guides: https://github.com/zeromq/libzmq#installation-of-binary-packages-\n"; \
 	      exit 1; \
 	    fi; \
 	  elif [ "$(TARGETOS)" = "darwin" ]; then \
-	    if [ -x "$(command -v brew)" ]; then \
+	    if command -v brew >/dev/null 2>&1; then \
 	      brew install zeromq; \
 	    else \
-	      echo "Homebrew is not installed and is required to install zeromq. Install it from https://brew.sh/"; \
+	      echo "⚠️ Homebrew is not installed and is required to install zeromq. Install it from https://brew.sh/"; \
 	      exit 1; \
 	    fi; \
 	  else \
-	    echo "Unsupported OS: $(TARGETOS). Install libzmq manually - check https://zeromq.org/download/ for guidance."; \
+	    echo "⚠️ Unsupported OS: $(TARGETOS). Install libzmq manually - see https://zeromq.org/download/"; \
 	    exit 1; \
 	  fi; \
 	  echo "✅ ZMQ dependencies installed."; \