Skip to content

Conversation

@npolshakova
Copy link
Contributor

@npolshakova npolshakova commented Aug 21, 2025

Was getting errors with the linter on the commit hook, realized I was using a different version than CI. Adds a check to the makefile to validate the golangci-lint version is compatible.

@mayabar
Copy link
Collaborator

mayabar commented Sep 16, 2025

Hi @npolshakova , this PR has been open for a few weeks and there’s still an issue to address. Do you plan to continue working on it, or should we take it over from here?

@npolshakova
Copy link
Contributor Author

npolshakova commented Sep 16, 2025

Hi @npolshakova , this PR has been open for a few weeks and there’s still an issue to address. Do you plan to continue working on it, or should we take it over from here?

Sorry, haven't had too much time for this. I think the fix should be pretty simple (locally the golanglint seems to be passing for me, but it looks like I'm using an older version and they switched the field name to linters_settings). Will try to get this in a good state by the end of the week. If that doesn't happen, let close it out.

It turns out it was the golangci-lint version all along 🤦‍♀️

Signed-off-by: npolshakova <[email protected]>
@npolshakova npolshakova changed the title Fix linter errors and settings Add golangci-lint version check Sep 16, 2025
@mayabar
Copy link
Collaborator

mayabar commented Sep 17, 2025

/lgtm
/approve

@github-actions github-actions bot added the lgtm label Sep 17, 2025
@github-actions github-actions bot merged commit a6c16ab into llm-d:main Sep 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants