feat: add helm charts for Kubernetes deployment #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmuelk
requested changes
Sep 2, 2025
Makefile
Outdated
| .PHONY: check-alias | ||
| check-alias: check-container-tool | ||
| @echo "🔍 Checking alias functionality for container '$(PROJECT_NAME)-container'..." | ||
| @echo "🔍 Checking alias functionality for container '$(PROJECT_NAME)-container'வுகளை..." |
There was a problem hiding this comment.
I think some strange characters have been added here
There was a problem hiding this comment.
ok, I'll fix it asap
Blackoutta
force-pushed
the
feature/add-helm
branch
from
fb01fe0 to
46a0878
Compare
Blackoutta
force-pushed
the
feature/add-helm
branch
from
46a0878 to
6d3fb63
Compare
|
@Blackoutta Please note that one of your commits is missing sign-off |
Signed-off-by: Blackoutta <[email protected]>
Blackoutta
force-pushed
the
feature/add-helm
branch
from
6d3fb63 to
68bcfd3
Compare
fixed! |
|
@Blackoutta Please sign your commit with a signature that is veriffied on Github. |
shmuelk
approved these changes
Sep 2, 2025
|
/lgtm /approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Thanks for the reminder, I've just got my gpg key set up on github, it'll show the 'verified' banner on my commits next time ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Helm charts to the llm-d-inference-sim repository.
Changes
helmdirectory.values.yamlfile.Testing
The Helm chart has been tested locally using minikube.
Related issue
Closes #181